[Sugar-devel] [PATCH] Only add one time every object in the clipboard v3 - SL #3371

[Simon Schampijer]

On 04/20/2012 11:01 PM, Anish Mangal wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sat 21 Apr 2012 02:23:57 AM IST, Gonzalo Odiard wrote:
>>      * Also, as the ticket mentions, if an already existing clipboard entry
>>      is selected, it isn't moved visually to the bottom of the list. This,
>>      IMO is a bug (deviance from time-ordered-sorting approach).
>>
>>
>> I don't think so. The active item is not the last one, but the
>> selected (active) radio button.
>> In fact, if you have more than one object in the clipboard, you can
>> select the active, doing click on it, but not dragging it to the
>> bottom. May be this was planned (there are comments about this in the
>> code), but was not implemented in this way.
>>
>
> I just tested without the patch, and the list of icons in the frame,
> _is_ indeed sorted in the order they were selected. I don't know about
> the 'active' entry though (you're perhaps right about that). What I'm
> saying is that the result of your patch, though it does add a
> functionality, but changes the preset 'visual ordering convention', if
> there was one.
>
> Maybe Gary can comment?

Ok, with Gonzalo's patch the UI is the following:

- copy 'hello'
---> 'hello' clipping is last item in the tray, 'hello' is selected
- copy 'world'
---> 'world' clipping is last item in the tray, 'world' is selected
- copy 'hello'
---> 'world' clipping is last item in the tray, 'hello' is selected

Before it was like:

- copy 'hello'
---> 'hello' clipping is last item in the tray, 'hello' is selected
- copy 'world'
---> 'world' clipping is last item in the tray, 'world' is selected
- copy 'hello'
---> 'hello'2 clipping is last item in the tray, 'hello'2 is selected

The behavior for the user when doing a paste is the same now. The visual 
ordering when there is a duplicate has changed, but to me this does not 
look too off-putting. I think Gary is aware of that if I remember the 
chat on irc about it correctly.

Regards,
    Simon