[Sugar-devel] [PATCH] Draw accelerator in Palette SL #3459

Simon Schampijer simon at schampijer.de
Fri Apr 20 06:53:57 EDT 2012


On 04/19/2012 04:41 PM, Daniel Drake wrote:
> On Wed, Apr 18, 2012 at 2:35 PM, Simon Schampijer<simon at schampijer.de>  wrote:
>> The accelerator in the primary information in the Palette
>> has not been drawn because there was not enough space
>> reserved for it. The preferred size we get back for the
>> Palette window does not include the accelerator of the
>> Gtk.AccelLabel. We need to include that in our calculation for
>> the Palette size.
>>
>> In order to make that information available which is part
>> of the Palette class we need to pass the instance to the
>> PaletteWindowWidget instance.
>
> Looks good. Having the do_get_preferred_width implementation in the
> Palette class was a definite oddity because Palette is not a GTK
> widget and so this was never called.
>
> Thanks
> Daniel

Yes, was a left over from restructuring. I will keep on looking for more :)

Pushed as 
http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/7a07bb10015e80fd34164da0d66ec54700df96df

Regards,
    Simon



More information about the Sugar-devel mailing list