[Sugar-devel] [PATCH sugar] Anly approve and not handle channels in the shell, part of OLPC #10738

Simon Schampijer simon at schampijer.de
Mon May 23 07:20:17 EDT 2011


On 05/20/2011 11:08 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Thu Apr 28 21:18:31 +0200 2011:
>> On 04/15/2011 06:47 PM, Sascha Silbe wrote:
>> [...]
>>> Given that "filt" is non-empty, do we really need the explicit
>>> conversions? I.e. would the following work?
>
>> No, we really need the explicit conversion:
> [error message that happens otherwise]
>
> The reason for this was recently mentioned [1] on the dbus mailing list:
>
>>>> Because dbus-python guesses the dictionary type by looking at the first
>>>> key-value pair which is 's' and 's' in this case.
>
>>>> You can use dbus.Dictionary({'name': 'test', 'id': 10}, signature='sv')
>>>> to explicitly tell it what type the dictionary should have.

Ok, thanks for the link.

> I already gave my Ack and can push the patch for you if you want.

As this patch is linked to the sugar-toolkit one "Handle DBUS tubes in 
the activity telepathy client, part of OLPC #10738" I want to push both 
at the same time - hence wait for ack on this one as well :)

Regards,
    Simon


More information about the Sugar-devel mailing list