[Sugar-devel] [PATCH sugar-datastore 2/3] Make sure data store checkouts are read-only

[Sascha Silbe]

We don't want anyone to be able to alter a file that is inside the data store,
bypassing the API.

Signed-off-by: Sascha Silbe <silbe at activitycentral.com>
---
 src/carquinyol/filestore.py |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)

diff --git a/src/carquinyol/filestore.py b/src/carquinyol/filestore.py
index 5f518ab..a614329 100644
--- a/src/carquinyol/filestore.py
+++ b/src/carquinyol/filestore.py
@@ -133,14 +133,6 @@ class FileStore(object):
             else:
                 raise
 
-        # Try to make the original file readable. This can fail if the file is
-        # in a FAT filesystem.
-        try:
-            os.chmod(file_path, 0604)
-        except OSError, e:
-            if e.errno != errno.EPERM:
-                raise
-
         return destination_path
 
     def get_file_path(self, uid):
@@ -223,7 +215,7 @@ class AsyncCopy(object):
     def start(self):
         self.src_fp = os.open(self.src, os.O_RDONLY)
         self.dest_fp = os.open(self.dest, os.O_RDWR | os.O_TRUNC | os.O_CREAT,
-                0644)
+                0444)
 
         stat = os.fstat(self.src_fp)
         self.size = stat[6]
-- 
1.7.2.3