[Sugar-devel] [PATCH sugar-toolkit] Avoid showing decorated windows during start-up (OLPC#10713)

[Sascha Silbe]

Excerpts from Daniel Drake's message of Sat Mar 05 13:11:51 +0100 2011:

> Out of interest, where is the existing code that makes things go
> maximized/fullscreen (even if it does happen a bit late)?

Check out jarabe.model.shell.ShellModel._window_opened_cb():

[...]
            if activity_id:
                home_activity = self.get_activity_by_id(activity_id)

                xid = window.get_xid()
                gdk_window = gtk.gdk.window_foreign_new(xid)
                gdk_window.set_decorations(0)

                window.maximize()
[...]

I wonder what the original reason was for doing it in the Shell. All
comments / descriptions I could find (including a small patch [1] that
introduced the relevant code above) didn't contain any rationale.

Commenting out the code starting at xid = ... (with the sugar-toolkit
patch applied) didn't show any obvious effects for sugar-toolkit based
activities. Etoys breaks as expected (i.e. has window decoration and
isn't maximised), but shouldn't be too hard to fix.

Sascha

[1] https://bugs.sugarlabs.org/attachment/ticket/602/0001-Change-window-management-stuff-so-Sugar-can-use-a-st.patch
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 494 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110305/1a033d5d/attachment.pgp>