[Sugar-devel] [PATCH sugar] Make sure the entry has the right color when copying from external device to Journal SL #2690

[Simon Schampijer]

On 06/09/2011 05:27 PM, Simon Schampijer wrote:
> On 06/07/2011 07:52 PM, Sascha Silbe wrote:
>> Excerpts from Simon Schampijer's message of Fri Jun 03 12:38:03 +0200
>> 2011:
>>
>> [src/jarabe/journal/model.py]
>>> @@ -615,6 +617,9 @@ def copy(metadata, mount_point):
>>> """Copies an object to another mount point
>>> """
>>> metadata = get(metadata['uid'])
>>> + if mount_point == '/' and metadata['icon-color'] == '#000000,#ffffff':
>>
>> Where does this colour come from? If we don't know the colour, why is it
>> set?
>>
>> Otherwise the patch looks fine.

Took that as an ack and pushed that patch now.

http://git.sugarlabs.org/sugar/mainline/commit/c628272dba4ffa14d65220463a663658462070c9

http://git.sugarlabs.org/sugar/mainline/commit/60d7e18c2f5a4c6d2522c51c3758cb13e671375c

Thanks for the review,
    Simon

>> Sascha
>
> By default the metadata for for a file on an external device has the
> black/white color [1]. When we now copy a file from an external device
> to the Journal we color the new Journal entry in our color.
>
> If we copy a Journal entry saved on machine A to machine B using an
> external device we want to keep the color information from machine A.
>
> Regards,
> Simon
>
> [1]
> http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/journal/model.py#line422
>
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>