[Sugar-devel] [PATCH] Use 'focus-out' event instead of 'changed' event for title entry

Simon Schampijer simon at schampijer.de
Mon Jun 20 11:57:29 EDT 2011


On 06/16/2011 02:27 PM, Simon Schampijer wrote:
> Hi,
>
> the patch does fix the bug where the cursor moves to the beginning of
> the entry field while trying to edit the activity instance name [1][2].
>
> Daniel and myself have been going through the old discussions and the
> 0.84 code and came up with two possible solutions [3][4]. Both do work
> and fullfill the test cases mentioned in the d.l.o ticket [5]. Both have
> down and upsides, either adding API [4], or having to find the title
> entry in a complex loop in order to scope for the different available
> toolbar solutions (old style/new style/sub-toolbar) [3].
>
> Sascha, would be great if you have a quick look which approach you like
> better and then we can send it for full review.
>
> Regards,
> Simon

Review done on irc, pushed as:

http://git.sugarlabs.org/sugar-toolkit/mainline/commit/746325106fb96fb9a4ad8fb45210dc1a60110ae8

http://git.sugarlabs.org/sugar-toolkit/mainline/commit/7a0d5d93984003d9d5964f593886dc6dee6dfb39

Regards,
    Simon


More information about the Sugar-devel mailing list