[Sugar-devel] [PATCH /sugar-jhbuild/source/pippy/data/math/factorial] Fix n variable error within the Factorial program in Pippy

James Cameron quozl at laptop.org
Tue Feb 22 22:19:24 EST 2011


On Tue, Feb 22, 2011 at 11:36:41PM -0300, Anish Mangal wrote:
> I've uploaded a new Pippy (39) to aslo. It should have the change
> (along with a bunch of pep8 and pylint cleanups) whenever its made
> public.

ef3edc36c1a1c06f19823bc7b99a880c48675dfa
Reviewed-by: James Cameron <quozl at laptop.org>

Sad to see the pep8 and pylint example changes go in, now there's
nothing for the kids to fix, it all looks too perfect.

Noted the change to credits near the end of the patch.  Thanks.

7a851677a70b56cd662b1fb25a4cc40f79d08da4
Reviewed-by: James Cameron <quozl at laptop.org>

Noted the simultaneous change of activity/activity.info and
pippy_app.py.  Have you any idea what pippy_activity_version() is for?
I can't figure it out.  I can't find a caller.
Activity.get_activity_version() seems to work fine in other contexts.

By the way, Pippy-38 contained .pippy_app.py.swp by accident.

-- 
James Cameron
http://quozl.linux.org.au/


More information about the Sugar-devel mailing list