[Sugar-devel] [SPAM?]: Re: [PATCH] Modify search icon to honor stroke and fill color

Simon Schampijer simon at schampijer.de
Mon Feb 7 11:54:31 EST 2011


Hi Gary,

On 02/04/2011 09:41 PM, Gary Martin wrote:
> Hi Simon,
>
> On 4 Feb 2011, at 17:05, Simon Schampijer<simon at schampijer.de>  wrote:
>
>> On 02/04/2011 08:17 AM, Gonzalo Odiard wrote:
>>> On Thu, Feb 3, 2011 at 4:26 PM, Simon Schampijer<simon at schampijer.de>wrote:
>>>
>>>> Hi Gonzalo,
>>>>
>>>> looks good to me. Please push to the master branch.
>>>>
>>>
>>> I think you added to Gonzalo Delgado, not me.
>>> I am godiard in git.
>>
>> Sorry, done now.
>>
>>>>  From the icons under icons/scalable/actions the logout icon does not honour
>>>> the stroke and fill colour - I would take a patch for that one, too :)
>>
>> @Gary, do you think it is safe to include in all those icons the stroke and fill colour? Do you think there was a specific reason to not do so for those icons?
>
> Just adding myself as a cc to the ticket, but I think these are safe for now as they are all intended as white toolbar icons, not ever user coloured items. I'll go through and tidy them up just so we have them all to the same standard - will make a git clone of sugar-artwork and submit a merge request once done.
>
> --G

Excellent! Sounds good.

Regards,
    Simon


More information about the Sugar-devel mailing list