[Sugar-devel] [PATCH] Add view source for sugar-toolkit

Simon Schampijer simon at schampijer.de
Fri Aug 19 08:13:11 EDT 2011


On 08/16/2011 05:16 PM, Simon Schampijer wrote:
> On 08/13/2011 05:14 PM, Walter Bender wrote:
>> From: Walter Bender<walter.bender at gmail.com>
>>
>> As per feedback from the design team, I have added a radio button to view
>> the source of the sugar-toolkit to the standard view source toolbar.
>>
>> Note: This is a modified version of an earlier patch that updates the
>> title
>> displayed in the View Source toolbar when switching between the
>> activity source
>> and the sugar-toolkit source. This patch also selects
>> activity/activity.py to
>> display in the viewer by default when looking at the sugar-toolkit
>> source.
>>
>> Note: There is one known issue: the treeview does not know that
>> activity.py
>> has been loaded into the viewer, so when you start to navigate the
>> sugar-toolkit source, you are started at root instead of the currently
>> opened branch.
>
> You can select the item when you pass the file_name to FileViewer (see
> attached patch). But for some reason this does not work if the file is
> under a folder. We should check if that is the case for general treeview
> item selection to rule that out (I don't think so).
>
> Regards,
> Simon
>
> PS: the other items in my patch are just cosmetic ones.

The patch needs to be rebased inorder to apply cleanly on current master.

Regards,
    Simon


More information about the Sugar-devel mailing list