[Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

Tomeu Vizoso tomeu at sugarlabs.org
Tue Sep 21 03:54:49 EDT 2010


On Mon, Sep 20, 2010 at 22:39, Sascha Silbe
<sascha-ml-reply-to-2010-3 at silbe.org> wrote:
> Excerpts from Tomeu Vizoso's message of Mon Sep 20 14:56:04 +0200 2010:
>
>> ---
>
> Would have been nice to note that this is a regression and callers
> expect the contact_id instead of the handle. At first I was worried that
> this might break other code, but the patch actually makes the listeners
> work again.

Seems like this bug has been there since the signal was added, but
indeed I can make explicit that I'm not changing the signal signature
but passing the expected argument.

Thanks,

Tomeu

> Reviewed-By: Sascha Silbe <sascha-pgp at silbe.org>
>
> Sascha
>
> --
> http://sascha.silbe.org/
> http://www.infra-silbe.de/
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>


More information about the Sugar-devel mailing list