[Sugar-devel] Home button in browse - toolbar images

Lucian Branescu lucian.branescu at gmail.com
Fri Oct 22 07:49:51 EDT 2010


On 22 October 2010 12:44, Gonzalo Odiard <gonzalo at laptop.org> wrote:
>
>
> On Fri, Oct 22, 2010 at 8:32 AM, Lucian Branescu <lucian.branescu at gmail.com>
> wrote:
>>
>> On 22 October 2010 12:05, Gonzalo Odiard <gonzalo at laptop.org> wrote:
>> > Lucien:
>> > I have added the patches to http://dev.laptop.org/ticket/10364
>> > Can you review it?
>>
>> Patch looks good, but it makes the toolbar extremely crowded. I'll
>> accept it for now, with the caveat of having a Browse toolbar overhaul
>> as soon as I get time for the other pressing issues (browse tab crash
>> and read brokenness).
>>
>
> Ok, if you want I can push it in 0.84 branch.

You should make a 0.90 branch first and then push your patch to the
master branch. We want to keep the 0.90 branch stable and only put in
manageable and low-risk fixes.

If you don't know how to make a branch, you'll have to wait 8-9h until
I get home.

> I agree with you, we must work in the toolbar.
>
> Gonzalo
>
>


More information about the Sugar-devel mailing list