[Sugar-devel] [PATCH] Make sure the buddy palette is disposed after popdown #1742

Tomeu Vizoso tomeu at sugarlabs.org
Thu Oct 14 12:03:33 EDT 2010


On Wed, Oct 13, 2010 at 18:29, Simon Schampijer <simon at schampijer.de> wrote:
> On 10/11/2010 11:35 AM, Tomeu Vizoso wrote:
>>
>> ---
>>  src/jarabe/view/buddyicon.py |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/jarabe/view/buddyicon.py b/src/jarabe/view/buddyicon.py
>> index 37b9167..15385bd 100644
>> --- a/src/jarabe/view/buddyicon.py
>> +++ b/src/jarabe/view/buddyicon.py
>> @@ -28,6 +28,8 @@ class BuddyIcon(CanvasIcon):
>>          self._buddy.connect('notify::present',
>> self.__buddy_notify_present_cb)
>>          self._buddy.connect('notify::color',
>> self.__buddy_notify_color_cb)
>>
>> +        self.palette_invoker.transient = True
>> +
>>          self._update_color()
>>
>>      def create_palette(self):
>
> This does set it to transient for all the buddies palletes, as well the one
> from the owner. As the owner palette has no dynamic content I guess we don't
> need to.

It's no big deal, but I think we should stop caching as many palettes
as possible.

Regards,

Tomeu

> Regards,
>   Simon
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>


More information about the Sugar-devel mailing list