[Sugar-devel] [PATCH v3 sugar] Pulsing icon delayed by 5 seconds or so SL#2080

[James Cameron]

On 09/10/2010, at 10:51 PM, Anurag Chowdhury wrote:
> --- a/src/sugar/graphics/animator.py
> +++ b/src/sugar/graphics/animator.py
> @@ -140,6 +140,9 @@ class Animation(object):
>             # last frame
>             frame = self.end
>         else:
> +            for i in range(5):
> +                easing = EASE_IN_EXPO
> +                duration = duration * 100
>             if easing == EASE_OUT_EXPO:
>                 frame = change * (-pow(2, -10 * t / duration) + 1) + start
>             elif easing == EASE_IN_EXPO:

I don't see the point of assigning a value to easing and then testing for a different value.

I also don't see why a value should be assigned to easing five times, when once would be sufficient.

With Daniel, I don't understand how this patch solves the problem you describe.

--
James Cameron
System Test Coordinator
One Laptop per Child