[Sugar-devel] Paint: patch to OLPC #3696 The freeform polygon tool should be in the Shapes toolbar

Tomeu Vizoso tomeu at tomeuvizoso.net
Tue May 25 03:08:01 EDT 2010


On Tue, May 25, 2010 at 08:51, Gonzalo Odiard <godiard at gmail.com> wrote:
>
> On Tue, May 25, 2010 at 1:49 AM, James Cameron <quozl at laptop.org> wrote:
>>
>> On Sun, May 23, 2010 at 12:26:15AM -0300, Gonzalo Odiard wrote:
>> > From 0f99bd0b5d6d03dfe6673d944764a9346427dee1 Mon Sep 17 00:00:00 2001
>> > From: Gonzalo Odiard <godiard at gmail.com>
>> > Date: Sat, 22 May 2010 10:16:52 -0300
>> > Subject: [PATCH] move free form tool
>>
>> Your attached patch applied fine, but there were warnings about new
>> trailing whitespace.  You added blank lines just above
>> _configure_palette_shape_trapezoid by accident.
>>
> Sorry by this... again.
> How I can detect or avoid the trailing whitespaces problem?

You can detect them visually if you use colored git, just put this in
~/.gitconfig:

[color]
        diff = auto

I'm sure there are git hooks that will reject or maybe even
autocorrect patches with extraneous whitespace, but I still haven't
put time aside to investigate that.

Regards,

Tomeu


More information about the Sugar-devel mailing list