[Sugar-devel] [PATCH v1 00/10] Journal sorting by file size and creation time.

[Gary C Martin]

Hi Andrés,

On 24 May 2010, at 01:16, Andrés Ambrois wrote:

> On Sunday 23 May 2010 04:08:51 pm Michael Stone wrote:
>> Andrés,
>> 
>> I've read these patches and tested them locally (with minor changes due to
>> merge conflicts with some of my experimental work) and the results are quite
>> pleasing to me.
> 
> Thanks!
> 
>> The one issue that I would like you to fix before I merge these patches into 
> my
>> tree is that I would like you to include additional patches for the new 
> icons
>> that your ListViewButton requires to function as intended. 
>> 
>> (I don't really care whether the new icons are different from the old icons; 
> I
>> merely care that I still have a normal-looking ListViewButton after I select
>> one of your new sort modes rather than the thin grey bar that I currently 
> see.)
> 
> I only have the filesize icon I made for testing, but I usually stay away from 
> graphics work (I suck at GIMP). 
> 
> Gary, I see you uploaded [0] to the wiki, which is what this patchset is based 
> on. Do you have SVG versions of the icons you put in there?

No, but they soon could be. I'll SVG them, and email to you for inclusion in your patch (view-lastedit, view-created, view-size).

Regards,
--Gary