[Sugar-devel] [PATCH] Fix for Ticket #1927

[Anish Mangal]

Hi James,

Thanks for your feedback. Pls find the responses inlined.

> - the toolbar clear button does not always flash for 400ms, though the
>  stop and run buttons do.

It will flash for *atleast* 400 milliseconds. Since the "Run" process
actually takes some time to execute, it will be colored for that
duration.

> - the [h,v]panes have a very small grab area, and the availability of
>  grab is not obvious.

The correct way to address this would be to fix the sugar gtk theme.
There is no easy method that I know of that can fix this from within
pippy. Older gtk versions which had the gtk.Gtk[H,V]Paned objects
instead of the current gtk.[H,V]Paned objects had explicit
set_handle_size() and set_gutter_size() methods which are no longer
present.

> Breaks compatibility with Sugar 0.84.  "from sugar.graphics.toolbarbox
> import ToolbarBox" reports "ImportError: No module named toolbarbox".

Fixed. Can you please check again.

> There's also a trivial trailing whitespace warning from git when the
> patch is applied ... caused by one of the vectors in an SVG.

Can you indicate the line number in the patch where the warning
occurred. Since some lines in the svg images were more that 998
characters, I had to break them into two so that git format-patch
could work.

Best Regards,
Anish Mangal



On Wed, May 5, 2010 at 6:07 AM, James Cameron <quozl at laptop.org> wrote:
> Good work.  Tested on Sugar 0.88 on XO-1.5.  Works fine, apart from:
>
> - the toolbar clear button does not always flash for 400ms, though the
>  stop and run buttons do.
>
> - the [h,v]panes have a very small grab area, and the availability of
>  grab is not obvious.
>
> Breaks compatibility with Sugar 0.84.  "from sugar.graphics.toolbarbox
> import ToolbarBox" reports "ImportError: No module named toolbarbox".
>
> There's also a trivial trailing whitespace warning from git when the
> patch is applied ... caused by one of the vectors in an SVG.
>
> Reviewed-by: James Cameron <quozl at laptop.org>
> Tested-by: James Cameron <quozl at laptop.org>
>
> --
> James Cameron
> http://quozl.linux.org.au/
>