[Sugar-devel] [RFC PATCH v0 0/8] Journal sorting by file size and creation time.

Andrés Ambrois andresambrois at gmail.com
Sat May 1 15:33:48 EDT 2010


This patchset implements sorting in the Journal UI as described in [0]. 

This feature was requested in [1] and sponsored by Activity Central [2].

Sorting by filesize is vital in the field where users need to free up disk
space. Currently, the only way to find candidates for deletion is to access
the expanded view of each entry, one by one. This can be a very time consuming
process and often leads to indiscriminate deletion and thus potential loss of
valuable data. This is bad.

Sorting by creation time (ctime) is also implemented as described in the Design
Proposal.

This implementation currently lacks two aspects which I hope will be sorted out
in the review process:

1- The proposal does not include a specification for changing the order of the
sort. This patch assumes an ascending order.

2- There are no icons for the sorting criteria. Or at least I couldn't find the
ones presented in the proposal. I'm sure someone from the design team could
vectorize the ones there.

v0: Initial submission to sugar-devel

[0] http://wiki.sugarlabs.org/go/Design_Team/Proposals/Journal#Extended_list_view_palette
[1] http://bugs.sugarlabs.org/ticket/1915
[2] http://activitycentral.org

Andrés Ambrois (8):
  Journal: Retrieve ctime and filesize from the datastore.
  Add ctime and filesize columns to the journal list model.
  Add add_separator method for convenience.
  Add a ListViewButton to the journal search toolbar.
  Rename the date column to 'sort_column'
  Add sort_by method to the journal list view.
  Call sort_by in the list view when sorting is selected in the
    toolbar.
  Expandedentry: Try to use the filesize property.

 src/jarabe/journal/expandedentry.py   |    5 +-
 src/jarabe/journal/journalactivity.py |    5 ++
 src/jarabe/journal/journaltoolbox.py  |   75 ++++++++++++++++++++++++++++++++-
 src/jarabe/journal/listmodel.py       |   22 +++++++---
 src/jarabe/journal/listview.py        |   34 ++++++++++-----
 src/jarabe/journal/model.py           |    6 +-
 6 files changed, 124 insertions(+), 23 deletions(-)



More information about the Sugar-devel mailing list