[Sugar-devel] [PATCH] touchpad section for Sugar Control Panel

[Walter Bender]

On Thu, Jul 29, 2010 at 6:27 AM, pbrobinson at gmail.com
<pbrobinson at gmail.com> wrote:
> On Wed, Jul 28, 2010 at 3:41 PM, Sascha Silbe
> <sascha-ml-ui-sugar-devel at silbe.org> wrote:
>> Excerpts from Paul Fox's message of Wed Jul 28 16:01:22 +0200 2010:
>>> sascha wrote:
>>>  > Even your latest patch still contains code that is specific to OLPC builds and will break on other systems.
>>>  > Of course it's perfectly fine for you to say you only care about OLPC builds for XO-1 (because the number of XO-1s running non-OLPC builds is minimal, especially if you don't count developers). But in that case your patch should be included in the OLPC builds, not in Sugar mainline.
>>>
>>> can you remind me of the specific issue(s) here?
>> I can remember two issues (there might be others as well):
>> - hardcoded, absolute path (/home/olpc/whatever)
>
> I agree that it shouldn't ever user /home/olpc as hardcoded. At least
> you ~/.olpc-blah as it will then work on what ever distro and what
> ever user. I'm not sure of the general standard to use for this.

How's this look?

35,36c35,36
< # FLAG_PATH is used to preserve status between boots.
< FLAG_PATH = '/home/olpc/.olpc-pentablet-mode'
---
> # FLAG_FILE is used to preserve status between boots.
> FLAG_FILE = '.olpc-pentablet-mode'
123a124
>     _flag_path = os.join(os.environ['HOME'], FLAG_FILE)
125,126c126,127
<         if os.path.exists(FLAG_PATH):
<             os.remove(FLAG_PATH)
---
>         if os.path.exists(_flag_path):
>             os.remove(_flag_path)
128c129
<         flag_file_handle = open(FLAG_PATH, 'w')
---
>         flag_file_handle = open(_flag_path, 'w')

-walter
>
> Peter
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>



-- 
Walter Bender
Sugar Labs
http://www.sugarlabs.org