[Sugar-devel] [PATCH] Journal Volumes Backup and Restore

[Martin Abente]

On Thu, 1 Jul 2010 21:18:54 +0100, Gary Martin
<garycmartin at googlemail.com>
wrote:
> On 29 Jun 2010, at 19:56, Martin Abente <mabente at paraguayeduca.org>
wrote:
> 
>> Martin and James,
>> 
>> In case you haven't noticed, we know how it could be better and we know
>> how the high level pseudo code would look like. We just can't do it,
>> because we have no more time to spend on this.
>> 
>> The backup and restore script are just a little part of this whole
patch,
>> and it would be _very_ helpful if someone could actually test it and
>> review
>> the code.
>> 
>> Thanks for your comments, hopefully we or someone else will have the
time
>> to improve it, in the near future.
>> _______________________________________________
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
> 
> On Thu, 1 Jul 2010 19:50:02 +0100, Gary Martin
> <garycmartin at googlemail.com>
> wrote:
>> On 1 Jul 2010, at 14:02, Tomeu Vizoso <tomeu at sugarlabs.org> wrote:
>> 
>>> On Wed, Jun 30, 2010 at 03:57, Bernie Innocenti <bernie at codewiz.org>
>>> wrote:
>>>> == New Features ==
>>>> 
>>>> sugar/backup-0001-Volumes-Backup-and-Restore.patch
>>>> sugar/backup-0002-Journal-XS-backup-and-restore.patch
>>>> 
>>>> There are concerns about restore deleting new entries since the
>>>> last backup. I agree, but since nobody seems to have the time to
>>>> implement and test a more sophisticated procedure, at this time
>>>> this is the best restore feature we have for Sugar.
>>> 
>>> Do we know any other deployment willing to deploy this?
>>> 
>>> If we decide to merge it, I think it should be disabled by default and
>>> have a gconf setting, because knowingly shipping a feature that causes
>>> data loss may not be a good idea.
>> 
>> Sounds fair. I was going to suggest making sure there was at least a
>> second user action needed after hitting a backup or restore button (I
>> skimmed through the patch code but couldn't see a conformation warning
>> step). A warning notification with Cancel/Backup, and Cancel/Restore
>> could
>> help avoid some accidents.
> 
> Just posting on this email thread as well. Not being sarcastic here :-p
> genuine question, is there a trac ticket for this one? Some patches do,
> some patches don't.
> 

:) Don't worry my sarcasm detection module is disabled anyways (such a
waste of resources).

Well, actually.. no, no ticket for this patch. If you think we need it I
can create one. But since the discussion started here already it could get
confusing if we try to move it to the trac.

Back to your comments. You are partially right, there is no explicit
warning about the current content deletion, but there is a Dialog before
starting the backup or restore process. Maybe I should add that warning
text (Actually I think Original Esteban Arias code had it). 

What do you think about: "WARNING: Current Journal content will be
deleted."

Btw, is there any WARNING icon in sugar?

> Regards,
> --Gary