[Sugar-devel] pylint / pep8 (was: Re: review queue)

[Sascha Silbe]

On Wed, Jan 27, 2010 at 03:59:31PM +0100, Tomeu Vizoso wrote:

> Hmm, this is a good suggestion, but I think we should make pylint
> installation and running a bit easier, I think we have regressed there
> in jhbuild.
I don't think we can get much easier for pylint:

sascha.silbe at twin:~$ ~/sugar-jhbuild/sugar-jhbuild run pylint sugar
Warning: unknown distro version, automatic fallback to unstable.
sascha.silbe at twin:~$


We could certainly improve on the current code quality so patch 
submitters have a better time finding their own mistakes:

(sugar-jhbuild)sascha.silbe at twin:~$ ~/sugar-jhbuild/sugar-jhbuild run 
pylint jarabe |egrep -v '^([ *]|$)' |cut -d : -f 1 |sort |uniq -c|sort 
-n -r

** (pylint:16720): WARNING **: Trying to register gtype 
'XklEngineFeatures' as flags when in fact it is of type 'GEnum'

** (pylint:16720): WARNING **: Trying to register gtype 
'WnckWindowState' as flags when in fact it is of type 'GEnum'

** (pylint:16720): WARNING **: Trying to register gtype 
'WnckWindowActions' as flags when in fact it is of type 'GEnum'

** (pylint:16720): WARNING **: Trying to register gtype 
'WnckWindowMoveResizeMask' as flags when in fact it is of type 'GEnum'
       81 E1101
       11 W0622
        9 W0621
        9 C0322
        7 W6501
        6 W0611
        4 W0612
        2 E1120
        2 C0301
        1 W0702
        1 W0402



I'm in the process of adding pep8 to sugar-jhbuild as well.

CU Sascha

-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: Digital signature
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100127/542877c5/attachment.pgp