[Sugar-devel] [PATCH] sl#2544 Adding Smiley Support to Chat Application
sascha-ml-reply-to-2010-4 at silbe.org
Tue Dec 28 12:24:21 EST 2010
Excerpts from Mukesh Gupta's message of Sun Dec 26 20:13:57 +0100 2010:
> +def from_svg_at_size(filename=None, width=None, height=None, handle=None,
> + keep_ratio=True):
> + """Scale and load SVG into pixbuf"""
> +def create_pngs():
I wonder if we could instead add persistent cache support to
sugar-toolkit (sugar.graphics.icon._IconBuffer is an in-memory cache for
SVGs). Other activities are likely to benefit from that.
> + sodipodi:docbase="/home/jimmac/src/cvs/tango-icon-theme/scalable/emotes"
This looks like it got copied from tango-icon-theme which is already
packaged for distros (at least Debian ships it; can't check Fedora
right now). Please add a dependency instead of copying files. Copies
have a strong tendency of getting outdated.
If you want XO bundles to work on older builds which might not have
shipped the tango-icon-theme package, you can still include the files
in the bundle by copying from the system location while creating the
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 490 bytes
Desc: not available
More information about the Sugar-devel