[Sugar-devel] [PATCH] fix journal scan of external media, dev.laptop.org #10140

[James Cameron]

On Tue, Nov 30, 2010 at 03:32:57PM +0100, Sascha Silbe wrote:
> Excerpts from James Cameron's message of Tue Nov 30 01:14:14 +0100 2010:
> 
> [src/jarabe/journal/model.py]
> 
> > +        if self._date_start is not None and self.st_mtime < self._date_start:
> > +            return
> > +
> > +        if self._date_end is not None and self.st_mtime > self._date_end:
> > +            return
> 
> Both occurrences of self.st_mtime need to read stat.st_mtime instead
> (found by pylint).

Sigh.  You suggested splitting these tests, expanding the scope of my
patch.  I now regret accepting the suggestion.  I think I should stick
to the changes I want to make, not the changes other people want me to
make.  When enthusiasm for a change is low, the defect rate is high.

-- 
James Cameron
http://quozl.linux.org.au/