[Sugar-devel] [PATCH] _update_signal_match wasn't initialized

[James Cameron]

On Mon, Apr 26, 2010 at 03:50:17PM -0400, Raul Gutierrez Segales wrote:
> Because of missing initialization and a weak test for the existence of
> the object  (self._update_signal_match is not None) Turtle Art was
> crashing when resuming from the Journal.

Reviewed, but I didn't understand.  This might be my fault.

Your patch appears to be to sugar-toolkit.

self._update_signal_match is only used in DSObject, it is already
initialised in sugar-toolkit 0.84.9, and you're adding the
initialisation to DSMetadata, where it is not used.

-- 
James Cameron
http://quozl.linux.org.au/