[sugar] [PATCH] Merge the journal activity into the shell

Marco Pesenti Gritti mpgritti
Wed Sep 10 20:39:41 EDT 2008


On Wed, Sep 10, 2008 at 2:58 PM, Tomeu Vizoso <tomeu at tomeuvizoso.net> wrote:
>> * I wonder if it would be easier to add a "builtin" journal activity
>> to the registry, instead of special casing the model.
>
> Not sure, a couple of ifs may be less confusing.

Hmmm not fully convinced, but I don't have a strong feeling. Something
we can easily refactor anyway.

The patch seem to have caused some pylint regressions:

http://buildbot.sugarlabs.org/builders/fedora9-x86_64-quick/builds/177/steps/pylint/logs/stdio

and some warnings at runtime (they don't prevent the activity to start):

http://buildbot.sugarlabs.org/builders/fedora9-x86_64-quick/builds/177/steps/ui-check/logs/stdio

Marco



More information about the Sugar-devel mailing list