[sugar] [Code-review] Please review recent rainbow patches.

Simon Schampijer simon
Mon Sep 1 05:17:11 EDT 2008


It works but in the removing of rainbow/sugaractivity patch you have to 
include a little change.

rainbow/rainbow/service.py:50:preload_common_modules 
'rainbow.sugaractivity'

Best,
    Simon

Marco Pesenti Gritti wrote:
> I tested it a bit and the fixes for #5428 and #7921 seems to work. Can
> we get it in joyride asap to get more testing?
> 
> Thanks,
> Marco
> 
> On Thu, Aug 28, 2008 at 4:21 AM, Michael Stone <michael at laptop.org> wrote:
>> Folks,
>>
>> I've got a small flurry of rainbow patches (everything from
>> rainbow-0.7.19..HEAD in http://dev.laptop.org/git/users/mstone/security)
>> that could use a bit of review.
>>
>> Many thanks,
>>
>> Michael
>>
>> P.S. - http://teach.laptop.org/~mstone/rainbow.rpm is an RPM containing
>> these patches. It's as yet untested, so I may well have broken things;
>> however, fixing that can happen in parallel with the review. :)
>>
>> P.P.S. - I still haven't figured out how to really fix #8016 except by
>> excruciatingly dirty hacks. Any thoughts would be appreciated. :(
>> _______________________________________________
>> Code-review mailing list
>> Code-review at lists.laptop.org
>> http://lists.laptop.org/listinfo/code-review
>>
> _______________________________________________
> Sugar mailing list
> Sugar at lists.laptop.org
> http://lists.laptop.org/listinfo/sugar
> 




More information about the Sugar-devel mailing list