[sugar] [PATCH] Add speaker device and icon by default

Martin Dengler martin
Mon May 12 16:42:00 EDT 2008


On Tue, May 06, 2008 at 05:40:30PM +0100, Martin Dengler wrote:
> On Tue, May 06, 2008 at 04:39:30PM +0200, Tomeu Vizoso wrote:
> > On 5/4/08, Martin Dengler <martin at martindengler.com> wrote:
> > > On Tue, Apr 29, 2008 at 02:12:58PM +0200, Tomeu Vizoso wrote:
> > > > I think that Michael has spotted here a wonderful opportunity for
> > > > making Sugar more robust, thanks to your patch.
> ...
> > > I haven't forgotten this thread, just been unable to work on it.

After working on it a bit more I think the right thing to do is just
the small change Tomeu suggested.

I would really like in the future to submit a patch that allows one to
place a few files in a devices.d/ subdir - like model.py, view.py,
icon.svg, etc. - and then the devicesmodel.py code could try to load
each model.py appropriately, and so forth, but right now most of our
"devices" really are device brokers (hal-dbus, networkmanager) and
such a setup doesn't mesh well with them.  Obviously in this patch
would be the "do the initialization lazily and safely"-type of code
that would make m_stone a lot happier.

But in the meantime the two/three lines Tomeu suggested will still
make things safer without adding lots of code; I will resubmit the
patch and hopefully that will make everyone a bit happier.

> > Thanks,
> > 
> > Tomeu
> 
> Martin

Martin


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080512/ab15e976/attachment.pgp 



More information about the Sugar-devel mailing list