[Bugs] #3974 sugar-artwork HIGH: Buttons: theme 'active' state correctly

[Sugar Labs Bugs]

#3974: Buttons: theme 'active' state correctly
------------------------------+---------------------------------------------
    Reporter:  erikos         |          Owner:  manuq   
        Type:  defect         |         Status:  new     
    Priority:  High           |      Milestone:  0.98    
   Component:  sugar-artwork  |        Version:  0.97.x  
    Severity:  Critical       |       Keywords:          
Distribution:  Fedora         |   Status_field:  Assigned
------------------------------+---------------------------------------------

Comment(by manuq):

 The proper way to do the icon switch colors in the active state is making
 a theme engine.  This is how the gtk2 engine was doing for changing the
 color of insensitive icons:

 - In toolkit icon.py the style.render_icon is called
 [http://git.sugarlabs.org/sugar-
 toolkit/mainline/blobs/master/src/sugar/graphics/icon.py#line244 here],
 and that is handled by the gtk2 theme [http://git.sugarlabs.org/sugar-
 artwork/mainline/blobs/master/gtk/engine/sugar-style.c#line836 here],
 which calls [http://git.sugarlabs.org/sugar-
 artwork/mainline/blobs/master/gtk/engine/sugar-style.c#line896 this
 function] that [http://git.sugarlabs.org/sugar-
 artwork/mainline/blobs/master/gtk/engine/sugar-utils.c#line44 change the
 svg].

 So we should create a gtk3 engine and reimplement
 [http://developer.gnome.org/gtk3/stable/GtkStyleContext.html#gtk-render-
 icon gtk_render_icon] or look for a workaround.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3974#comment:4>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system