[Bugs] #2062 UNSP: Trying to register to XS while offline produces in no user visible errors

[Sugar Labs Bugs]

#2062: Trying to register to XS while offline produces in no user visible errors
------------------------------------------+---------------------------------
    Reporter:  bernie                     |          Owner:  timclicks                  
        Type:  defect                     |         Status:  accepted                   
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  sugar                      |        Version:  Git as of bugdate          
    Severity:  Unspecified                |       Keywords:  sugar-love r!              
Distribution:  Unspecified                |   Status_field:  Unconfirmed                
------------------------------------------+---------------------------------

Comment(by timclicks):

 Replying to [comment:6 tomeu]:
 > Removing from the queue until it's clear which is the patch awaiting for
 review.

 Sorry for not responding to your earlier comment. This is the patch for
 review:

 {{{
 #!diff
 diff --git a/src/jarabe/desktop/schoolserver.py
 b/src/jarabe/desktop/schoolserver.py
 index fc9ddeb..a05f56c 100644
 --- a/src/jarabe/desktop/schoolserver.py
 +++ b/src/jarabe/desktop/schoolserver.py
 @@ -99,7 +99,7 @@  def register_laptop(url=REGISTER_URL):
      server = ServerProxy(url)
      try:
          data = server.register(sn, nick, uuid_, profile.pubkey)
 -    except (Error, socket.error):
 +    except (Error, TypeError, socket.error):
          logging.exception('Registration: cannot connect to server')
          raise RegisterError(_('Cannot connect to the server.'))
 }}}

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/2062#comment:7>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system