[Bugs] #1440 UNSP: sugar-emulator: kill X server on exit

[Sugar Labs Bugs]

#1440: sugar-emulator: kill X server on exit
------------------------------------------+---------------------------------
    Reporter:  sascha_silbe               |          Owner:  sascha_silbe     
        Type:  defect                     |         Status:  accepted         
    Priority:  Unspecified by Maintainer  |      Milestone:  0.88             
   Component:  sugar                      |        Version:  Git as of bugdate
    Severity:  Major                      |       Keywords:  r?               
Distribution:  Unspecified                |   Status_field:  Assigned         
------------------------------------------+---------------------------------
Changes (by alsroot):

  * milestone:  0.86 => 0.88


Comment:

 {{{
  alsroot │ tomeu: what do you think about
 http://bugs.sugarlabs.org/ticket/1440's last patch
    tomeu │ alsroot: at first sight, it looks good, but I don't feel
 comfortable pushing that one because I don't fully understand
          │ the implications of using subprocess.call instead of os.execlp
    tomeu │ alsroot: in my experience, these calls have subtle effects that
 have been hard to track in the past
    tomeu │ such changes are better to do early in the cycle
    tomeu │ we are never going to have a stable release if we keep doing
 such changes
  alsroot │ tomeu: so, maybe add comments to ticket and switch to 0.88?
  alsroot │ and unfortunately this patch doesn't fix my issue when after
 killing metacity, sugar doesn't stop immediately and if
          │ user hit ^C it breaks "dbus-launcher --exit-with-session" logic
  alsroot │ ..and it houldn't by desing
  alsroot │ s/it/that patch/
      <-- │ GintasDX (n=GintasDX at m83-188-160-191.cust.tele2.lt) has left
 #sugar ()
      --> │ lucian (i=80f0e544 at gateway/web/freenode/x-rwklhfokzbvhxctj) has
 joined #sugar
    tomeu │ alsroot: how are you killing metacity?
  alsroot │ tomeu: by `kill`
  alsroot │ ..and its only after update to last system stuff
    tomeu │ alsroot: ok, so I think we should play safe here and only risk
 if users really need something done about it
 }}}

 In mind this issue is not so critical, user sees Xephyr window and can
 close it explicitly, so lets commit original patch to 0.88.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1440#comment:4>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system