[Sugar-devel] [PATCH v2 sugar] Finish port of palettes in network device icon

Manuel Quiñones manuq at laptop.org
Tue Sep 25 19:36:17 EDT 2012


2012/9/25 Simon Schampijer <simon at schampijer.de>:
> Thanks Manuel.
>
>
> On 09/25/2012 08:42 PM, Manuel Quiñones wrote:
>>
>> Started in aaa963cf with the port of wireless.  The pending one was
>> GsmPalette.  WiredPalette doesn't need to be changed, it doesn't pack
>> MenuItems, just sets the content with set_content, is all
>> informational.  And device type OLPC mesh uses the same palette as
>> wireless, already ported.
>
>
> Excellent, thanks for checking all the different cases.
>
>
>> - use PaletteMenuItem instead of MenuItem
>> - fixed the calls to set_label of the menu item
>> - use update_state instead of unexistent set_state
>>
>> This needs to be properly tested with a modem connection.
>
>
> Please push, and thanks for your extra test case. I am sure we get more
> testing once it is landed.

Yes I hope.  Pushed as aec34420 .  Thanks.

-- 
.. manuq ..


More information about the Sugar-devel mailing list