[Sugar-devel] [PATCH Browse] Cancel a download if space is very tight SL #394

[Gonzalo Odiard]

On Wed, Sep 12, 2012 at 9:26 AM, Martin Langhoff
<martin.langhoff at gmail.com>wrote:

> On Wed, Sep 12, 2012 at 8:20 AM, Manuel Kaufmann <humitos at gmail.com>
> wrote:
> > OK. I was taking a look at the datastore source code and I understood
> > that the file is copied, using the traditional way and when the copy
> > finishes the source file is unlinked.
>
> Ouch! I haven't reviewed the code (have to run some personal errands
> today, can't dig into it as I'd like), but if you are correct, there
> are two worries
>
>  - Downloading a 100MB file needs >200MB+ free.
>

Yes, we need verify this.


>  - All that passing around the file to update the percentage bar is
> causing pointless file copies -- if you are downloading a large file,
> it is pretty screwed.
>
>
I think the percentage is related to the metadata, no to the file size
change.

Gonzalo



> cheers,
>
>
> m
> --
>  martin.langhoff at gmail.com
>  martin at laptop.org -- Software Architect - OLPC
>  - ask interesting questions
>  - don't get distracted with shiny stuff  - working code first
>  - http://wiki.laptop.org/go/User:Martinlanghoff
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120912/d73e2ed1/attachment-0001.html>