[Sugar-devel] [PATCH v2 sugar] Work around for fullscreen bug (SL #2180)
tomeu at sugarlabs.org
Mon Sep 27 10:00:39 EDT 2010
On Sat, Sep 25, 2010 at 17:06, Dipankar Patro <dipankar at seeta.in> wrote:
> Previously some bottom part of sugar emulator window was pushed out
> of viewing area at 800x600 system resolution.
> Modified the code to include the resolution 800x600 for fullscreen
> execution, since we cannot predict the space of different OS task
> pannels/bars/ window title bars.
Patch looks good to me, please send it again with a commit message
that describes what the patch is for (for example: open sugar-emulator
in fullscreen mode by default if the screen is <= 800x600).
Also please ask for submittal once we have branched 0.90, it will be
in a few days from now and will be announced in sugar-devel.
> src/jarabe/util/emulator.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> v1->v2: Rebased on current mainline/master
> diff --git a/src/jarabe/util/emulator.py b/src/jarabe/util/emulator.py
> index 6a43044..cc112c9 100644
> --- a/src/jarabe/util/emulator.py
> +++ b/src/jarabe/util/emulator.py
> @@ -42,7 +42,7 @@ def _run_xephyr(display, dpi, dimensions, fullscreen):
> screen_size = (gtk.gdk.screen_width(), gtk.gdk.screen_height())
> if (not dimensions) and (fullscreen is None) and \
> - (screen_size < default_dimensions) :
> + (screen_size <= default_dimensions) :
> # no forced settings, screen too small => fit screen
> fullscreen = True
> elif (not dimensions) :
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
More information about the Sugar-devel