[Sugar-devel] [PATCH] sugar-artwork: stricter compiler flags
quozl at laptop.org
Tue May 11 20:36:42 EDT 2010
On Tue, May 11, 2010 at 06:56:14PM -0400, Bernie Innocenti wrote:
> WARN_CFLAGS was already used in gtk/engine/Makefile.am, but not
> initialized by configure.
> For backwards compatibility, GCC's by default is very permissive.
> In my case, it was silently miscompiling code which was calling
> a non-existent GTK function. For this particular case, the
> proposed WARN_CFLAGS should make the build fail early in this case.
> I'm not proposing -Werror because it frequetly results in broken
> builds for trivial reasons when distros update the toolchain.
> Signed-off-by: Bernie Innocenti <bernie at codewiz.org>
Trivial error in comment: s/sublte/subtle
Tested using autogen and make on Debian Squeeze. Nothing bad appears to
Reviewed-by: James Cameron <quozl at laptop.org>
Tested-by: James Cameron <quozl at laptop.org>
More information about the Sugar-devel