[Sugar-devel] code submitted for review should have been tested

James Cameron quozl at laptop.org
Wed Aug 11 20:18:25 EDT 2010


On Wed, Aug 11, 2010 at 12:22:00PM +0200, Tomeu Vizoso wrote:
> any code contributor is expecting that their patches will be tested by
> the reviewer?

I don't think a reviewer should be expected to test patches as part of
a review process, but if they choose to test then they should indicate
this in their review comments.  In the sign-off method of patch review,
there's a tag "Tested-by" which is different to "Reviewed-by".

-- 
James Cameron
http://quozl.linux.org.au/


More information about the Sugar-devel mailing list