[sugar] [PATCH] Journal able to use "open with" for activity bundles
Jameson "Chema" Quinn
Wed May 28 15:44:13 EDT 2008
On Wed, May 28, 2008 at 12:16 PM, Tomeu Vizoso <tomeu at tomeuvizoso.net>
> + if self._jobject.is_activity_bundle():
> + menu_item = MenuItem(_('Start'))
> + menu_item.connect('activate',
> + None)
> + palette.menu.append(menu_item)
> + menu_item.show()
> Why are we adding a Start menu item? How is it different from clicking
> on the button?
We add a start menu item in case there is a choice to run or open with; if
there are choices, they should all be listed, even if one is available in a
simpler way (by just clicking). Also note that I plan, in the future, to
make the default behavior (clicking on the button) configurable using
metadata, so that you can have some bundles which are "for editing".
> - self._jobject.resume(service_name)
> + if not service_name:
> + self._jobject.resume()
> + else:
> + self._jobject.resume(service_name)
> Why is this needed? self._jobject.resume(service_name) when
> service_name == None should be the same as self._jobject.resume().
> The rest seems good to me.
> Sugar mailing list
> Sugar at lists.laptop.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Sugar-devel