[sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function
Marco Pesenti Gritti
Fri Jun 6 15:24:11 EDT 2008
On Fri, Jun 6, 2008 at 6:13 PM, Jameson Chema Quinn
<jquinn at cs.oberlin.edu> wrote:
> Note: this patch does not expose the fix_manifest function when running
> bundlebuilder as a script. That would be a 2 or 3 line patch, seperately.
Some initial notes:
* Please run pylint on the changed files. You can use
sugar-jhbuild/scripts/data/pylintrc. That will catch several problems
and nitpicks that I'd ask you to fix anyway.
* I dont understand all the
warnings.warn(MalformedBundleException(...)). What's the purpose of
those. Shouldn't they be real exceptions? What's the advantage of
using the warnings module over logging.warning?
* I'm not sure what you are using dest_dir for, but it looks like it
should be part of Config.
* Why are you moving the activity and env imports inline.
As we discussed in irc, it would be good to split up patches. But
anyway in the case of big patches like this, containing unrelated
changes is good to provide a list of the changes you made and the
reason you made them (can you provide such list when you resubmit the
patch with pylint fixed? Thanks!).
More information about the Sugar-devel