<div dir="ltr"><div>It turned out to be fairly simple to fix the Read Activity. It was complaining that it had no MICRO_VERSION attribute in the EvinceDocument object, so I just removed it from the _validate_min_version() method in evinceadapter.py: </div><div> </div><div><div style="background-color:rgb(255,255,255);padding:0px 0px 0px 2px"><div style="color:rgb(0,0,0);background-color:rgb(255,255,255);font-family:"Monospace";font-size:10pt;white-space:pre"><div style="background-color:rgb(255,255,255);padding:0px 0px 0px 2px"><div style="color:rgb(0,0,0);background-color:rgb(255,255,255);font-family:"Monospace";font-size:10pt;white-space:pre"> def update_toc(self, activity): if self._validate_min_version(3, 5): # check version because does not work and crash with older evince doc = self._model.get_document() if not doc.has_document_links(): logging.error('The pdf file does not have a index') return False else: self._job_links = EvinceView.JobLinks.new(document=doc) self._job_links.connect('finished', self.__index_loaded_cb, activity) EvinceView.Job.scheduler_push_job( self._job_links, EvinceView.JobPriority.PRIORITY_NONE) return True else: return False def handle_link(self, link): self._view.handle_link(link) def _validate_min_version(self, major, minor): """ Check if Evince version is at major or equal than the requested """ evince_version = [EvinceDocument.MAJOR_VERSION, EvinceDocument.MINOR_VERSION] return evince_version >= [major, minor] </div></div>Now it works. I was getting the same error from the version of Read Activity that shipped with Fedora 39. I made a pull request for Get IA Books. It looks like I can do the merge myself. Not sure of what the procedure is to get the revised Activity published. James Simmons </div></div></div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 16, 2024 at 5:47 PM James Cameron <<a href="mailto:quozl@laptop.org">quozl@laptop.org</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Thanks. What about the activity provided by Fedora 39? On Fri, Feb 16, 2024 at 05:28:35PM -0600, James Simmons wrote: > I just confirmed that the master branch of the Read Activity has this problem > with Evince when running on Fedora 39: > > Traceback (most recent call last): > File "/usr/bin/sugar-activity3", line 5, in <module> > activityinstance.main() > File "/usr/lib/python3.12/site-packages/sugar3/activity/activityinstance.py", > line 230, in main > instance = create_activity_instance(activity_constructor, activity_handle) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "/usr/lib/python3.12/site-packages/sugar3/activity/activityinstance.py", > line 59, in create_activity_instance > activity = constructor(handle) > ^^^^^^^^^^^^^^^^^^^ > File "/home/jamessimmons/git/read-activity/readactivity.py", line 374, in > __init__ > self.read_file(self._jobject.file_path) > File "/home/jamessimmons/git/read-activity/readactivity.py", line 747, in > read_file > self._load_document('file://' + tempfile) > File "/home/jamessimmons/git/read-activity/readactivity.py", line 1054, in > _load_document > self._update_toc() > File "/home/jamessimmons/git/read-activity/readactivity.py", line 627, in > _update_toc > if self._view.update_toc(self): > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "/home/jamessimmons/git/read-activity/evinceadapter.py", line 275, in > update_toc > if self._validate_min_version(3, 5, 92): > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "/home/jamessimmons/git/read-activity/evinceadapter.py", line 301, in > _validate_min_version > EvinceDocument.MICRO_VERSION] > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "/usr/lib64/python3.12/site-packages/gi/module.py", line 126, in > __getattr__ > raise AttributeError("%r object has no attribute %r" % ( > AttributeError: 'gi.repository.EvinceDocument' object has no attribute > 'MICRO_VERSION'. Did you mean: 'MINOR_VERSION'? > Exited with status 1, pid 106639 activity_id > 37db76336c5474c61078f525c28c1f9de48fab9a > > James Simmons > > On Fri, Feb 16, 2024 at 4:09 PM James Simmons <[1]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a>> wrote: > > James, > > I'm using Fedora 39, a fresh install on a computer I just got and an older > one I'm giving away. I'm using the version of Read that ships with Fedora. > I just checked out the master branch of Read from Git and could run a > python 3 setup.py dev on it to see if that version has the problem. I won't > be able to do that right away, but when I do I'll let you know if it works. > > James Simmons > > On Fri, Feb 16, 2024 at 3:42 PM James Cameron <[2]<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>> wrote: > > That's surprising. Thought we fixed that. > > What Linux distribution and release are you doing this on? > > On Fri, Feb 16, 2024 at 02:23:11PM -0600, James Simmons wrote: > > James, > > > > I don't want to use Evince as part of Get IA Books. It is the Read > Activity > > itself that has a problem. > > > > When I tested opening books from the Journal the Read Activity would > not start. > > I thought the problem might be in the way Get IA Books was adding > books to the > > Journal, so as a sanity check I used the Browse activity to download > some PDFs > > to the Journal and also downloaded one EPUB. The Read Activity opened > the EPUB > > just fine but not the PDFs. There was a stack trace (copied to an > earlier > > email) that made it look like the code Evince needs to interface with > Python > > has changed. It was complaining about an Evince micro version number. > That was > > the thing I wanted to look at in the Read Activity. > > > > I'll probably send an email to the wider group explaining the issue. > > > > Thanks. > > > > James Simmons > > > > On Fri, Feb 16, 2024 at 2:01 PM James Cameron <[1][3]<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a> > > wrote: > > > > There's also VScode and GitHub desktop if you want to try other > > methods. It is difficult to keep up with GitHub's security > posture > > lately. > > > > The Read activity has the integration with Evince. If you want > your > > activity to show PDF inside it, rather than activate Read, then > borrow > > code from Read. > > > > By the way, you're using our membership team alias, which is just > > Alex, myself, and Ibiam. If you'd like wider and public > readership, > > there's the sugar-devel@ mailing list. > > > > [2][4]<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > > > > On Fri, Feb 16, 2024 at 08:03:20AM -0600, James Simmons wrote: > > > Ibiam, > > > > > > I think the problem is I need to use a Personal Access Token > with > > Eclipse. > > > Somehow it worked with my regular password from Windows at work > but it > > was > > > rejected when I used the command line at home from Linux. I had > to use > > the PAT > > > instead of the regular password. > > > > > > I'm going to try to get the Read Activity working with Evince. > I won't > > need Git > > > update permission unless I actually succeed. > > > > > > James Simmons > > > > > > On Fri, Feb 16, 2024 at 7:40 AM Chihurumnaya Ibiam <[1][3] > > [5]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a>> > > > wrote: > > > > > > Maybe there's an issue with the integration in Eclipse. > > > > > > Glad to hear it's working fine from the command line. > > > > > > On Thu, Feb 15, 2024 at 5:32 PM James Simmons <[2][4] > > [6]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a>> > > > wrote: > > > > > > Chihurumnaya, > > > > > > > > > I did some testing with command line Git and my push > worked fine. > > I was > > > trying to use Eclipse as my IDE, which has Git > integration built > > in. > > > That works fine for pulls and for cloning the > repository but not > > for > > > pushes, at least not if you use the https:// URL. > > > > > > I can easily live with doing pushes from the command > line. > > > > > > Thanks for your help. > > > > > > James Simmons > > > > > > > > > On Thu, Feb 15, 2024 at 7:42 AM Chihurumnaya Ibiam <[3] > > > [5][7]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a>> wrote: > > > > > > That's strange, can you use the -v arg so we can > see some > > verbose > > > output, I can confirm you have admin access to the > repo. > > > > > > On Thu, Feb 15, 2024 at 1:41 AM James Simmons <[4] > > > [6][8]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a>> wrote: > > > > > > Ibiam, > > > > > > I just tried it. I get this error: > > > > > > Can't connect to any repository: [5][7][9] > <a href="https://github.com" rel="noreferrer" target="_blank">https://github.com</a> > > / > > > sugarlabs/getiabooks.git ([6][8][10]https:// > <a href="http://github.com/" rel="noreferrer" target="_blank">github.com/</a> > > sugarlabs/ > > > getiabooks.git: not authorized) > > > > > > I try logging in as [7][9][11] > <a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> (as I log > > into the > > > website) and also jdsimmons. Both display the > login > > dialog > > > multiple times and give up. > > > > > > It looks like I can create branches OK on the > website. > > > > > > Any suggestions? > > > > > > James Simmons > > > > > > On Wed, Feb 14, 2024 at 11:33 AM James Simmons > <[8] > > > [10][12]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a>> wrote: > > > > > > Thanks. It looks OK. I won't be able to try > it out > > until > > > this evening. > > > > > > James Simmons > > > > > > On Wed, Feb 14, 2024 at 11:18 AM > Chihurumnaya Ibiam > > <[9] > > > [11][13]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a>> wrote: > > > > > > I've added you as a collaborator to the > repo with > > admin > > > access. > > > > > > On Wed, Feb 14, 2024 at 6:12 PM James > Simmons > > <[10] > > > [12][14]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a>> wrote: > > > > > > Many years ago I wrote Activities > for Sugar > > and the > > > maintenance of those Activities has > been > > taken over > > > by others. One such Activity is: > > > > > > [11][13][15]<a href="https://github.com/" rel="noreferrer" target="_blank">https://github.com/</a> > sugarlabs/ > > getiabooks > > > > > > I'm preparing one of my used > computers to > > give to a > > > bright eight year old boy and I > wanted to > > give him > > > a working Sugar environment in > addition to > > other > > > cool Linux stuff. Get IA Books > stopped > > working > > > because the Internet Archive > changed their > > advanced > > > search and also the formats that > they > > generate for > > > their titles, but I've got it > mostly working > > again > > > and I'd like to create a branch and > a pull > > request > > > for this and other Activities I > created which > > need > > > to be upgraded to Python 3. The Get > Books > > Activity > > > needs to be upgraded also and I can > do the > > work on > > > that one as well. They share a > certain amount > > of > > > code. > > > > > > It appears that I am not allowed to > create > > branches > > > and push changes to them. My id in > GitHub is > > > jdsimmons and I'm shown as a past > contributor > > to > > > this Activity. CAn I be given this > access? > > > > > > Thanks, > > > > > > James Simmons > > > > > > References: > > > > > > [1] mailto:[14][16]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > > > [2] mailto:[15][17]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > > [3] mailto:[16][18]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > > > [4] mailto:[17][19]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > > [5] [18][20]<a href="https://github.com/sugarlabs/getiabooks.git" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks.git</a> > > > [6] [19][21]<a href="https://github.com/sugarlabs/getiabooks.git" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks.git</a> > > > [7] mailto:[20][22]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > > [8] mailto:[21][23]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > > [9] mailto:[22][24]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > > > [10] mailto:[23][25]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > > [11] [24][26]<a href="https://github.com/sugarlabs/getiabooks" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks</a> > > > > References: > > > > [1] mailto:[27]<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a> > > [2] [28]<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > > [3] mailto:[29]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > > [4] mailto:[30]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [5] mailto:[31]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > > [6] mailto:[32]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [7] [33]<a href="https://github.com/" rel="noreferrer" target="_blank">https://github.com/</a> > > [8] [34]<a href="https://github.com/sugarlabs/" rel="noreferrer" target="_blank">https://github.com/sugarlabs/</a> > > [9] mailto:[35]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [10] mailto:[36]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [11] mailto:[37]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > > [12] mailto:[38]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [13] [39]<a href="https://github.com/sugarlabs/getiabooks" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks</a> > > [14] mailto:[40]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > > [15] mailto:[41]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [16] mailto:[42]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > > [17] mailto:[43]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [18] [44]<a href="https://github.com/sugarlabs/getiabooks.git" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks.git</a> > > [19] [45]<a href="https://github.com/sugarlabs/getiabooks.git" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks.git</a> > > [20] mailto:[46]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [21] mailto:[47]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [22] mailto:[48]<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > > [23] mailto:[49]<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > > [24] [50]<a href="https://github.com/sugarlabs/getiabooks" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks</a> > > References: > > [1] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [2] mailto:<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a> > [3] mailto:<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a> > [4] <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > [5] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [6] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [7] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [8] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [9] <a href="https://github.com/" rel="noreferrer" target="_blank">https://github.com/</a> > [10] <a href="https://github.com/" rel="noreferrer" target="_blank">https://github.com/</a> > [11] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [12] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [13] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [14] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [15] <a href="https://github.com/sugarlabs/" rel="noreferrer" target="_blank">https://github.com/sugarlabs/</a> > [16] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [17] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [18] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [19] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [20] <a href="https://github.com/sugarlabs/getiabooks.git" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks.git</a> > [21] <a href="https://github.com/sugarlabs/getiabooks.git" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks.git</a> > [22] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [23] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [24] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [25] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [26] <a href="https://github.com/sugarlabs/getiabooks" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks</a> > [27] mailto:<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a> > [28] <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > [29] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [30] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [31] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [32] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [33] <a href="https://github.com/" rel="noreferrer" target="_blank">https://github.com/</a> > [34] <a href="https://github.com/sugarlabs/" rel="noreferrer" target="_blank">https://github.com/sugarlabs/</a> > [35] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [36] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [37] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [38] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [39] <a href="https://github.com/sugarlabs/getiabooks" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks</a> > [40] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [41] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [42] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [43] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [44] <a href="https://github.com/sugarlabs/getiabooks.git" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks.git</a> > [45] <a href="https://github.com/sugarlabs/getiabooks.git" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks.git</a> > [46] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [47] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [48] mailto:<a href="mailto:members@sugarlabs.org" target="_blank">members@sugarlabs.org</a> > [49] mailto:<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a> > [50] <a href="https://github.com/sugarlabs/getiabooks" rel="noreferrer" target="_blank">https://github.com/sugarlabs/getiabooks</a> </blockquote></div>