<div dir="ltr">I took a better look and I agree with James, I've made my comment on the PR.<br clear="all"><div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><pre style="color:rgb(46,52,54);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px"><span style="font-family:monospace,monospace">-- <br></span></pre><div style="color:rgb(46,52,54);font-size:14.6667px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;width:71ch"><span style="font-family:monospace,monospace"><span></span><span></span>Ibiam Chihurumnaya</span></div><div style="color:rgb(46,52,54);font-size:14.6667px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;width:71ch"><span style="font-family:monospace,monospace"><a href="mailto:ibiam@sugarlabs.org" target="_blank">ibiam@sugarlabs.org</a><br></span></div><br></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Aug 12, 2023 at 5:16 PM James Cameron <<a href="mailto:quozl@laptop.org">quozl@laptop.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sat, Aug 12, 2023 at 04:33:00PM +0200, Dimitris20Cen wrote:<br>
> Text Dungeon:<br>
> <br>
> - Licensing concerns:<br>
> <br>
> - As text dungeon is an existing activity, its licensing process is<br>
> intricate.<br>
<br>
Actually, the license is correctly defined as GPLv2+ in the metadata, the COPYING file is properly present, and two of the three Python source files have the correct license declaration with valid copyrights. There's no problem with licensing of the existing activity, as at f7f53e2 ("Deanglify links to <a href="http://help.sugarlabs.org" rel="noreferrer" target="_blank">help.sugarlabs.org</a>") on the master branch.<br>
<br>
> - Apart from licensing issues, the project is ready for release, if no other issues come up.<br>
<br>
What you are referring to here is your wholesale replacement for the activity, which is in the pull request yet to be merged.<br>
<br>
I'd like wider consultation on this. Would other developers please review the pull request and comments and give their opinion? The key issue is that the entire source code is removed and replaced; which we would normally handle by adding a new activity repository with the new source code, with a new activity name.<br>
<br>
<a href="https://github.com/sugarlabs/textdungeon/pull/14" rel="noreferrer" target="_blank">https://github.com/sugarlabs/textdungeon/pull/14</a><br>
<br>
Also, the existing issues have not been specifically addressed; presumably they are all fixed?<br>
_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
</blockquote></div>