<div dir="ltr"><div>Thanks for the feedback Ibiam.<br><br>> Would the ghost lines for dots and boxes appear on mouse hover?</div><div>Yes, the lines would be drawn on hover, again to indicate where the new line will be placed on click.<br><br><br><div>> Simulate activity sometimes crashes Sugar, what do you mean by crashing Sugar?</div><div>I was not able to reproduce it but I do have the error saved. by crash, I mean that the activity stops responding completely, including the stop button and pressing CTRL+Q, I had to go back to the journal and then remove the activity, after that I got an error in the terminal. <br>here is the error : <a href="https://pastebin.com/1RcTvYHc">https://pastebin.com/1RcTvYHc</a> <br></div><div><br></div><div><br></div><div>> too many unknowns, you mention implementing an AI but no details as to how you intend to go about it, what data would you use?</div><div>As for the AI, I specified using the minimax algorithm to implement the AI, which is a tree based algorithm specializing in two player games, including othello which is what reversi is based off.<br>As to how I would be making the AI play the game, I would call the minimax function to get the ideal move and then place the piece on the board by calling the self.board_model.put_piece function of ReversiController class and instead of toggling player like in normal mode, the toggle_current_player function would call the minimax function.<br><br></div><div><br></div><div>> What new dependencies would you be adding to the activity?</div><div>No new dependencies will be required.</div><div><br></div><div><br></div><div>> for reversi activity, is collaboration working fine?<br>No, collaboration is not implemented for this activity<br><br><br>> Reset and next buttons in jumble activity not being visible, no images to explain again.</div><div> How can you click on them if they're not visible?</div><div>I will attach images to my proposal to explain further.<br>I can click them as the buttons are still there and function properly, just that they are not visible. Again, I will attach images to elaborate<br><br><br>>
Nutrition activity: "having premade questions" any sample of such questions would be helpful.<br>I'd add a proper sample in the proposal, but it would be like for eg: A fast food item Vs a Salad, or pizza vs a vegetable.<br><br><br>- In response to IQ activity, thanks for the suggestion, I will add it to the proposal that I'll be making these settings optional.</div><div><br></div><div><br></div><div>>
how do you intend to "make sure".<br>after calling the _generate_color method of the BallsGenerator class, I'd calculate hsp<br>hsp = sqrt(<br> 0.299 * (r * r) +<br> 0.587 * (g * g) +<br> 0.114 * (b * b)<br> );<br>This is how hsp is calculated and if hsp is greater than 128, it means the color is bright enough for the text to be visible.<br>If it is not, I'd call the function again until the condition is satisfied. <br>This approach is better than generating the rgb values in the _generate_color function ranging from 128 to 255 because calculating hsp provides room for more colors than this approach. <br><br><br>Finally, Thanks for the review and I'll be adding all these to the proposal as well, and I'll attach images wherever needed, as you suggested when talking about flip activity.</div><div>I will soon be uploading the updated proposal</div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 31, 2023 at 8:30 PM Chihurumnaya Ibiam <<a href="mailto:ibiam@sugarlabs.org">ibiam@sugarlabs.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I forgot to add this for reversi activity, is collaboration working fine?<br clear="all"><div><div><div dir="ltr"><div dir="ltr"><pre style="color:rgb(46,52,54)"><span style="font-family:monospace,monospace">-- <br></span></pre><div style="color:rgb(46,52,54);font-size:14.6667px;width:71ch"><span style="font-family:monospace,monospace">Ibiam Chihurumnaya</span></div><div style="color:rgb(46,52,54);font-size:14.6667px;width:71ch"><span style="font-family:monospace,monospace"><a href="mailto:ibiam@sugarlabs.org" target="_blank">ibiam@sugarlabs.org</a><br></span></div><br></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 31, 2023 at 3:17 PM Chihurumnaya Ibiam <<a href="mailto:ibiam@sugarlabs.org" target="_blank">ibiam@sugarlabs.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi Spandan,</div><div><br></div><div>Thanks for sharing, a few comments.</div><div><br></div><div>Would the ghost lines for dots and boxes appear on mouse hover?</div><div><br></div><div>Simulate activity sometimes crashes Sugar, what do you mean by crashing Sugar?</div><div>What does the logs say?</div><div><br></div><div>When talking about images, the best way to explain is to add images to prove your point, the board size overflow you mentioned</div><div>in flip activity can better be understood with an image. <br></div><div>This also applies to every activity where you mention something that's wrong with the canvas.</div><div><br></div><div>Reset and next buttons in jumble activity not being visible, no images to explain again.</div><div>How can you click on them if they're not visible?</div><div><br></div><div>Reversi activity: too many unknowns, you mention implementing an AI but no details as to how you intend to go about it, what data would you use?</div><div>What new dependencies would you be adding to the activity?</div><div><br></div><div>Nutrition activity: "having premade questions" any sample of such questions would be helpful.</div><div>Where do you intend to get the healthy index from?</div><div><br></div><div>IQ activity: The timer idea seems nice but it should be optional as some kids might feel pressured when timed and the goal ultimately is</div><div>to have fun while playing.</div><div>Hard coding solutions doesn't sound intuitive, what happens if the board size changes in the future so that means the solutions would have to be hard coded again.</div><div><br></div><div>Hit the balls activity: "I intend on creating a utility function which generates a random color only after making sure the color is bright enough that the text on it would be visible."</div><div>Only after making sure sounds vague, how do you intend to "make sure".</div><div>Button hover sound doesn't seem right as hovering is not really an action the activity cares about.</div><div><br></div><div>Hope this helps!<br></div><div><br></div><div><br clear="all"><div><div dir="ltr"><div dir="ltr"><pre style="color:rgb(46,52,54)"><span style="font-family:monospace,monospace">-- <br></span></pre><div style="color:rgb(46,52,54);font-size:14.6667px;width:71ch"><span style="font-family:monospace,monospace">Ibiam Chihurumnaya</span></div><div style="color:rgb(46,52,54);font-size:14.6667px;width:71ch"><span style="font-family:monospace,monospace"><a href="mailto:ibiam@sugarlabs.org" target="_blank">ibiam@sugarlabs.org</a><br></span></div><br></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 31, 2023 at 8:23 AM Spandan Barve <<a href="mailto:spandan567@gmail.com" target="_blank">spandan567@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi everyone, I am Spandan Barve, also known as marsian83 on github. <br>Here is my draft GSOC 2023 proposal for the project : Improve and Maintain 12 sugar activities<br>Looking forward to a feedback from the mentors and any suggestions are welcome <br>Thanks<br><br><br></div>
_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a></blockquote></div></blockquote></div></blockquote></div></div>