<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<div>Thanks a lot! for the feedback. I have indented info.json file as
well and linted python files using flake8 (except some false-positives
& block comment remarks). I will address rest of the feedback when I
will be working on project next time.<br></div><div><br></div><blockquote class="tutanota_quote" style="border-left: 1px solid #93A3B8; padding-left: 10px; margin-left: 5px;"><div>The Browse activity in Sugar uses WebKit as an embedded browser, so<br></div><div>that's the browser that will be used most. Please add that to your<br></div><div>test process.<br></div></blockquote><p>I am testing with Browse activity, thanks for informing itโs using
WebKit engine. So, that means testing it with Epiphany browser in lieu
of WebKit itself should also work?<br></p><div><br></div><blockquote class="tutanota_quote" style="border-left: 1px solid #93A3B8; padding-left: 10px; margin-left: 5px;"><div>Copyright; please add your copyright to main.py.<br></div><div><div><br></div></div><div>License; please add a license grant after your copyright in main.py;<br></div><div>you have included AGPLv3 as a file, but have not followed the section<br></div><div>"How to Apply These Terms to Your New Programs".<br></div></blockquote><p>Yes, copyright & license is in To-Do list on README.md. It will be addressed next time.<br></p><div><br></div><blockquote class="tutanota_quote" style="border-left: 1px solid #93A3B8; padding-left: 10px; margin-left: 5px;"><div>User experience; the per-activity page seems redundant; there's no<br></div><div>additional information, and so the download link could have been<br></div><div>included in the search results instead of a link to the per-activity<br></div><div>page.<br></div></blockquote><p>I plan on adding detailed description and gallery parts in activity
page besides activity details specified in requirements. Where
available, these can be sourced from aslo. Activities page will also
serve for possible future extensions such as adding rating &
reviews. But yeah, there should be direct install/download button on
search page.<br></p><p>UI of prototype is just for demonstration of search functionality.
Exact presentation of information and UI design will be worked on but search results
might be displayed something like:<br></p><p>[ ICON] Activity Name<br>
Summary <i>if exists</i>, <i>else if</i> Description <i>if exists</i>, <i>else if</i> first 50 words/5 sentences of detailed description <i>if exists</i>, <i>else</i> nothing<br>
TAG1, TAG2, TAG3<br>
[Install/download button w/ version no. underneath it]<br></p><p>There would be no Summary, Description or Tags heading. This is just for letting know in demo what is the source of information.<br></p><div><br></div><blockquote class="tutanota_quote" style="border-left: 1px solid #93A3B8; padding-left: 10px; margin-left: 5px;"><div>Show the version of the activity.<br></div><div><div><br></div></div><div>Draw icons on a white background.<br></div><div><div><br></div></div><div>Bundle files should include a version number, so that if they are<br></div><div>downloaded they do not get renamed by browsers.<br></div><div><div><br></div></div><div>Bundle files could be hard linked instead of copied. This will be<br></div><div>faster.<br></div></blockquote><div>Got it ๐<br></div><div><br></div><blockquote class="tutanota_quote" style="border-left: 1px solid #93A3B8; padding-left: 10px; margin-left: 5px;"><div>Tags could be sent through an initial uppercase filter.<br></div></blockquote><p>Tags should be shown in ALL CAPS?<br></p><div><br></div><blockquote class="tutanota_quote" style="border-left: 1px solid #93A3B8; padding-left: 10px; margin-left: 5px;"><div>A view by unique tags.<br></div></blockquote><p>Option to filter result by tags? Awesome idea. Will do it.<br></p><p><br></p><div>Waiting for more through feedback as you get time.<br></div><p>Regards,<br>
Manish<br></p><div><br></div><div><br></div><div>Apr 25, 2020, 11:12 by quozl@laptop.org:<br></div><blockquote class="tutanota_quote" style="border-left: 1px solid #93A3B8; padding-left: 10px; margin-left: 5px;"><div>Thanks. Looks good so far. I've tested it on an OLPC server using<br></div><div>OLPC OS 20.04, which is based on Ubuntu 20.04 and Sugar 0.117, and I'm<br></div><div>able to search, download and use activities.<br></div><div><br></div><div>The Browse activity in Sugar uses WebKit as an embedded browser, so<br></div><div>that's the browser that will be used most. Please add that to your<br></div><div>test process.<br></div><div><br></div><div>Copyright; please add your copyright to main.py.<br></div><div><br></div><div>License; please add a license grant after your copyright in main.py;<br></div><div>you have included AGPLv3 as a file, but have not followed the section<br></div><div>"How to Apply These Terms to Your New Programs".<br></div><div><br></div><div>Coding style; please use flake8; it will speed review.<br></div><div><br></div><div>User experience; the per-activity page seems redundant; there's no<br></div><div>additional information, and so the download link could have been<br></div><div>included in the search results instead of a link to the per-activity<br></div><div>page.<br></div><div><br></div><div>Show the version of the activity.<br></div><div><br></div><div>Draw icons on a white background.<br></div><div><br></div><div>Bundle files should include a version number, so that if they are<br></div><div>downloaded they do not get renamed by browsers.<br></div><div><br></div><div>Bundle files could be hard linked instead of copied. This will be<br></div><div>faster.<br></div><div><br></div><div>The JSON could be indented.<br></div><div><br></div><div>Tags could be sent through an initial uppercase filter.<br></div><div><br></div><div>A view by unique tags.<br></div><div><br></div><div>I'll look further at these ideas next week.<br></div><div><br></div><div>On Fri, Apr 24, 2020 at 11:13:10PM +0200, sugar@radii.dev wrote:<br></div><blockquote><div>Hello everyone,<br></div><div><br></div><div>I have prepared prototype for:<br></div><div>a) client-side search engine which work even when html file is opened in<br></div><div>browser (without any localhost server). Browsers now (Firefox since v68)<br></div><div>restrict any direct calls requesting files (index) if html file is opened from<br></div><div>local drive. So, only option is to load index every time by including src in<br></div><div>page html. However defer its loading so that it doesn't slow page loading. Once<br></div><div>page is loaded than index can load in background.<br></div><div><br></div><div>b) script to generate website using website template and activity bundles<br></div><div>directory i.e. method to build index and activity page, extract activity icon<br></div><div>and copy activity bundle to website.<br></div><div><br></div><div>A demo of it is available at: [1]https://activities.radii.page/<br></div><div>Repository is available at: [2]https://github.com/free-libre-software/<br></div><div>sugarappstore and [3]https://radii.dev/sugarlabs/appstore<br></div><div><br></div><div>Further information such as how to use and design choices are available in<br></div><div>repository's README.md page. Please read through it.Also, please review code<br></div><div>(even though its rough for prototype) and give feedback. If any significant<br></div><div>change need to be made with coding such as coding style, structuring etc. than<br></div><div>now is a good time to let me know.<br></div><div><br></div><div>I request everyone to download repo, try and give your feedback. It should not<br></div><div>take more than 10 mins to test if you already have lots of activity bundles.<br></div><div>Anyone who wish to do code contribution is welcomed. The faster we are able to<br></div><div>build, the sooner people can use it.<br></div><div><br></div><div>I have few suggestions for aslo (activities.sugarlabs.com). I will try to raise<br></div><div>issue on its repository if I get some time available. Otherwise, I will<br></div><div>directly send pull request when free. Issues are very simple. So, if someone<br></div><div>wants to take initiative than please do:<br></div><div>1) Redirect http -> https version where browser supports<br></div><div>2) Since Fedora 32 SoaS final version is about to be released which will not<br></div><div>support python2 activities, we need to redirect them to new app store (when<br></div><div>basic functionalities built). also uses Apache server as backend and here are<br></div><div>three different scenarios to choose from:<br></div><div> a) (good) redirect only users landing at home page to new website by<br></div><div>editing .htaccess file in directory<br></div><div> b) (Best) a) + redirect per activity bases as well to activity page on new<br></div><div>website<br></div><div> c) (bad) redirect users from all pages to home page of new app store. Will<br></div><div>require editing virtual host config in Apache.<br></div><div>3) Activities download over http even when on https page. At least download <br></div><div>links are not hard coded to http urls. So, it could be somewhere in the backend<br></div><div>code. Some other urls are hard coded though. If its static website (I doubt)<br></div><div>than we can write simple script to convert all http url to protocol unspecified<br></div><div>or https based on some logic (for eg. not all external links can be directed to<br></div><div>https like what if some website do not support https).<br></div><div><br></div><div>I will not be contributing next week as I have few school due dates in coming<br></div><div>days and I have to work on improving them. So, you can expect next update on<br></div><div>weekend after that.<br></div><div><br></div><div>Regards,<br></div><div>Manish<br></div><div><br></div><div>References:<br></div><div><br></div><div>[1] https://activities.radii.page/<br></div><div>[2] https://github.com/free-libre-software/sugarappstore<br></div><div>[3] https://radii.dev/sugarlabs/appstore<br></div></blockquote><blockquote><div>_______________________________________________<br></div><div>Sugar-devel mailing list<br></div><div>Sugar-devel@lists.sugarlabs.org<br></div><div>http://lists.sugarlabs.org/listinfo/sugar-devel<br></div></blockquote><div><br></div><div><br></div><div>-- <br></div><div>James Cameron<br></div><div>http://quozl.netrek.org/<br></div></blockquote><div><br></div> </body>
</html>