<div dir="ltr"><div class="gmail_default" style="font-size:large"><font face="verdana, sans-serif"></font></div><div dir="ltr"><div class="gmail_default" style="font-size:large"><font face="verdana, sans-serif">Hi Aniket,</font></div><div class="gmail_default" style="font-size:large"><font face="verdana, sans-serif"><br></font></div><div class="gmail_default" style="font-size:large"><font face="verdana, sans-serif">As the packages were incomplete, I removed the repo to avoid confusion. I've re-uploaded them and added a reference source to what steps I took to create the packages in the README. Also, please check James's comments regarding these packages.</font></div><div class="gmail_default" style="font-size:large"><font face="verdana, sans-serif"><br></font></div><div class="gmail_default" style="font-size:large"><font face="verdana, sans-serif">Thanks,</font></div><div class="gmail_default" style="font-size:large"><font face="verdana, sans-serif">Sukhdeep Gill</font></div></div><font face="verdana, sans-serif"><br></font><div class="gmail_quote"><div dir="ltr" class="gmail_attr"><font face="verdana, sans-serif">On Thu, Jul 25, 2019 at 10:38 PM ANIKET MATHUR <<a href="mailto:amathur@ec.iitr.ac.in">amathur@ec.iitr.ac.in</a>> wrote:<br></font></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><font face="verdana, sans-serif">G'day Sukhdeep, </font><div><font face="verdana, sans-serif">You have removed the packages repository from your github. I would be happy to analyze those packages.</font></div><div><font face="verdana, sans-serif">Also would you please tell how you proceeded?</font></div><div><font face="verdana, sans-serif"><br></font></div><div><font face="verdana, sans-serif">Thanks!</font></div></div><font face="verdana, sans-serif"><br></font><div class="gmail_quote"><div dir="ltr" class="gmail_attr"><font face="verdana, sans-serif">On Tue, Jul 23, 2019 at 2:58 PM James Cameron <<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>> wrote:<br></font></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><font face="verdana, sans-serif">On Tue, Jul 23, 2019 at 01:02:33PM +0530, sukhdeep gill wrote:<br>
> Python packages:<br>
> <a href="https://github.com/sukhdeepg/sugar-toolkit-gtk3-python-packages" rel="noreferrer" target="_blank">https://github.com/sukhdeepg/sugar-toolkit-gtk3-python-packages</a>.<br>
> This is the first step with respect to an earlier reply from James<br>
> Cameron. I've understood the depth of the issue from this result<br>
> after the Debian bug 931666 search. If this isn't the right way,<br>
> please let me know.<br>
<br>
Thanks. Happy to review. The main problem is that you did not<br>
examine the packages, compare them with Debian packages, or test the<br>
packages.<br>
<br>
(a) your package version should include something to discriminate<br>
against potential Debian packages yet to be provided by Debian<br>
developers, or packages by other Sugar Labs developers,<br>
<br>
(b) your package version should include the git hash; the file<br>
src/sugar3/util.py has the latest HEAD of 5043d53, but the version of<br>
your packages is 0.114-1,<br>
<br>
(c) your package python-sugar3_0.114-1_all.deb includes a Python 3<br>
program (sugar-activity3) and Python 2 artefacts in<br>
/usr/lib/python2.7/dist-packages/sugar3 ... but sugar-activity3 should<br>
not be present, and this is a fault of our build in<br>
sugar-toolkit-gtk3,<br>
<br>
(d) your package python-sugar3_0.114~python3-1_all.deb includes a<br>
Python 2 program (sugar-activity) and Python 2 artefacts in<br>
/usr/lib/python2.7/dist-packages/sugar3 ... but sugar-activity should<br>
not be present (this is a fault of our build in sugar-toolkit-gtk3)<br>
and the artefacts should be for Python 3 not Python 2,<br>
<br>
(e) both packages are named python-sugar3 ... but they should have<br>
different names (python-sugar3 and python3-sugar3), so they can be<br>
installed at the same time.<br>
<br>
Please do examine the packages and test them carefully before<br>
publishing your work. Test by installing the packages and running<br>
Sugar and the set of Fructose (core) activities.<br>
<br>
Hope that helps!<br>
<br>
-- <br>
James Cameron<br>
<a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a><br>
_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
</font></blockquote></div><font face="verdana, sans-serif">
_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a></font><br>
</blockquote></div></div>