<div dir="auto"><div dir="auto">James, that's great! Yup, I agree. ;-) </div> <div class="gmail_quote" dir="auto"><div dir="ltr">On Wed, 13 Mar 2019, 4:18 am James Cameron, <<a href="mailto:quozl@laptop.org">quozl@laptop.org</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We have a link in contributing.md; "We use the pull-request model, see [GitHub's help on pull-request](<a href="https://help.github.com/articles/using-pull-requests)" rel="noreferrer noreferrer" target="_blank">https://help.github.com/articles/using-pull-requests)</a>." But people can't be expected to remember everything. ;-) On Wed, Mar 13, 2019 at 02:24:44AM +0530, Sumit Srivastava wrote: > While I agree googling is an essential skill, we should probably add it in > docs, no? > > On Wed, 13 Mar 2019, 2:20 am James Cameron, <[1]<a href="mailto:quozl@laptop.org" target="_blank" rel="noreferrer">quozl@laptop.org</a>> wrote: > > Here's how to do it; > > [2]<a href="https://help.github.com/en/articles/creating-a-pull-request" rel="noreferrer noreferrer" target="_blank">https://help.github.com/en/articles/creating-a-pull-request</a> > > Our Sugar Labs documents for contributing don't have every answer, > sorry. Some skills are external. > > By the way, if you had made a local "git clone" on your own computer, > then done a "git push", the server will have sent back instructions > how to make a pull request. > > On Wed, Mar 13, 2019 at 01:54:51AM +0530, navyasri reddy wrote: > > I have changed the readme and pushed to forked repo in my github account. > How > > do I raise a pull request to original repo. I have seen the docs for > > contributing but didn't get it much. > > > > On Wed, Mar 13, 2019 at 12:15 AM Sumit Srivastava <[1][3] > <a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a>> > > wrote: > > > > Yes, Jaskirat. The reply all button is a wonderful little thing and > poses > > much less friction than new members would otherwise experience. > > > > On Wed, 13 Mar 2019, 12:06 am Jaskirat Singh, <[2][4] > <a href="mailto:juskirat2000@gmail.com" target="_blank" rel="noreferrer">juskirat2000@gmail.com</a>> > > wrote: > > > > Thanks Sumit, > > > > This sounds like a better choice for the people helping new > > contributors to get started. > > > > On Wed, 13 Mar 2019, 12:04 am Sumit Srivastava, <[3] > > [5]<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a>> wrote: > > > > Navya, > > > > Good to see you figuring out the codebase! Check out > instructions > > on downloading and running musicblocks. It should be present > in the > > musicblocks documentation. It states: > > > > "If you want to run Music Blocks offline, download this repo > and > > point your browser to the index.html file found in the > musicblocks > > directory on your local file system." > > > > Also, if you post your questions directly to [4] > > [6]<a href="mailto:sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">sugar-devel@lists.sugarlabs.org</a> , more people can come in > and > > contribute. I am sorry if you had a rough start but rest > assured, > > the community is awesome! > > > > I'll be available at sugar-devel mailing list and so would be > a lot > > other experienced developers in the community. Always better > to > > expose your questions to more people, right? For this thread, > you > > can use "reply-all" button on gmail to directly post to > sugarlabs > > devel list and me. > > > > Keep asking questions! :) > > > > Regards > > Sumit Srivastava > > > > On Tue, 12 Mar 2019, 11:51 pm navyasri reddy, <[5] > > [7]<a href="mailto:navyasrireddy1996@gmail.com" target="_blank" rel="noreferrer">navyasrireddy1996@gmail.com</a>> wrote: > > > > Hey, > > Thanks for helping me out with this. I have found through > the > > other issues that the sound sample need to have same > pitch > > through out which is not mentioned in the readme and also > > testing whether the sound is added properly or not is > also not > > there in the readme. > > I am not sure how to test it. Can you direct me so that i > can > > test and update readme. > > > > Thanks. > > > > On Mon, Mar 11, 2019 at 7:08 PM Sumit Srivastava <[6] > > [8]<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a>> wrote: > > > > Hi, navyasri! > > > > It'd be great if you post publicly to the sugar devel > > mailing list. While I have no problem with replying > to your > > question privately, the community as a whole benefits > more > > from public discussions like these. > > > > Don't worry you can post all kinds of beginner > questions, > > even the one you think might be silly, to the mailing > list. > > :) > > > > Here are the steps to approach the issue: > > > > -Fork the branch. > > > > -Take a look at the instructions to add sample sound. > > > > -Try and do it yourself. > > > > -Did you find instructions were useful? Do they need > to be > > updated? (Hint: Yes, because of which the issue was > > created) > > > > -Figure out how can you better explain the process > you > > followed to add a sample sound. > > > > -Write it down. > > > > -Commit to your branch, test, and then request to > merge. > > > > Regards > > Sumit Srivastava > > > > On Mon, 11 Mar 2019, 2:16 pm navyasri reddy, <[7] > > [9]<a href="mailto:navyasrireddy1996@gmail.com" target="_blank" rel="noreferrer">navyasrireddy1996@gmail.com</a>> wrote: > > > > Hey, > > This is navyasri. I wan to contribute to music > blocks > > by starting with some basic contribution (below > > attached). This is about updating readme but I am > not > > clear with the issue. There's no reply to extra > > information on this issue. A help for this would > be > > appreciated. > > [8][10]<a href="https://github.com/sugarlabs/musicblocks/" rel="noreferrer noreferrer" target="_blank">https://github.com/sugarlabs/musicblocks/</a> > issues/1468 > > > > Thanks, > > navyasri > > > > _______________________________________________ > > Sugar-devel mailing list > > [9][11]<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">Sugar-devel@lists.sugarlabs.org</a> > > [10][12]<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > > > > References: > > > > [1] mailto:[13]<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a> > > [2] mailto:[14]<a href="mailto:juskirat2000@gmail.com" target="_blank" rel="noreferrer">juskirat2000@gmail.com</a> > > [3] mailto:[15]<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a> > > [4] mailto:[16]<a href="mailto:sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">sugar-devel@lists.sugarlabs.org</a> > > [5] mailto:[17]<a href="mailto:navyasrireddy1996@gmail.com" target="_blank" rel="noreferrer">navyasrireddy1996@gmail.com</a> > > [6] mailto:[18]<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a> > > [7] mailto:[19]<a href="mailto:navyasrireddy1996@gmail.com" target="_blank" rel="noreferrer">navyasrireddy1996@gmail.com</a> > > [8] [20]<a href="https://github.com/sugarlabs/musicblocks/issues/1468" rel="noreferrer noreferrer" target="_blank">https://github.com/sugarlabs/musicblocks/issues/1468</a> > > [9] mailto:[21]<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">Sugar-devel@lists.sugarlabs.org</a> > > [10] [22]<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > > > _______________________________________________ > > Sugar-devel mailing list > > [23]<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">Sugar-devel@lists.sugarlabs.org</a> > > [24]<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > > -- > James Cameron > [25]<a href="http://quozl.netrek.org/" rel="noreferrer noreferrer" target="_blank">http://quozl.netrek.org/</a> > > References: > > [1] mailto:<a href="mailto:quozl@laptop.org" target="_blank" rel="noreferrer">quozl@laptop.org</a> > [2] <a href="https://help.github.com/en/articles/creating-a-pull-request" rel="noreferrer noreferrer" target="_blank">https://help.github.com/en/articles/creating-a-pull-request</a> > [3] mailto:<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a> > [4] mailto:<a href="mailto:juskirat2000@gmail.com" target="_blank" rel="noreferrer">juskirat2000@gmail.com</a> > [5] mailto:<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a> > [6] mailto:<a href="mailto:sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">sugar-devel@lists.sugarlabs.org</a> > [7] mailto:<a href="mailto:navyasrireddy1996@gmail.com" target="_blank" rel="noreferrer">navyasrireddy1996@gmail.com</a> > [8] mailto:<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a> > [9] mailto:<a href="mailto:navyasrireddy1996@gmail.com" target="_blank" rel="noreferrer">navyasrireddy1996@gmail.com</a> > [10] <a href="https://github.com/sugarlabs/musicblocks/issues/1468" rel="noreferrer noreferrer" target="_blank">https://github.com/sugarlabs/musicblocks/issues/1468</a> > [11] mailto:<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">Sugar-devel@lists.sugarlabs.org</a> > [12] <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > [13] mailto:<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a> > [14] mailto:<a href="mailto:juskirat2000@gmail.com" target="_blank" rel="noreferrer">juskirat2000@gmail.com</a> > [15] mailto:<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a> > [16] mailto:<a href="mailto:sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">sugar-devel@lists.sugarlabs.org</a> > [17] mailto:<a href="mailto:navyasrireddy1996@gmail.com" target="_blank" rel="noreferrer">navyasrireddy1996@gmail.com</a> > [18] mailto:<a href="mailto:sumitsrisumit@gmail.com" target="_blank" rel="noreferrer">sumitsrisumit@gmail.com</a> > [19] mailto:<a href="mailto:navyasrireddy1996@gmail.com" target="_blank" rel="noreferrer">navyasrireddy1996@gmail.com</a> > [20] <a href="https://github.com/sugarlabs/musicblocks/issues/1468" rel="noreferrer noreferrer" target="_blank">https://github.com/sugarlabs/musicblocks/issues/1468</a> > [21] mailto:<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">Sugar-devel@lists.sugarlabs.org</a> > [22] <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > [23] mailto:<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank" rel="noreferrer">Sugar-devel@lists.sugarlabs.org</a> > [24] <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > [25] <a href="http://quozl.netrek.org/" rel="noreferrer noreferrer" target="_blank">http://quozl.netrek.org/</a> -- James Cameron <a href="http://quozl.netrek.org/" rel="noreferrer noreferrer" target="_blank">http://quozl.netrek.org/</a> </blockquote></div></div>