<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Are you really saying that the 100+
activities ported to GTK+3 are simply changes and do not represent
a new version? <br>
<br>
When do you expect it will be possible to release any of these
ports. So far the only one I know is the release of turtleblocks v
218 by Walter Bender. I believe the github/repositories for
activities need to represent working versions and should at least
be one version number above those in ASLO preceding the changes.
I see no reason for using pull requests for less than a new
version.<br>
<br>
Let the users test the activity. The activity should be tested to
see that Browse downloads, installs and that the activity can
start in Ubuntu Sugar (18.04 LTS) and in build 13.2.9. If the new
version does not work in one of these environments, add this fact
to the release notes.<br>
<br>
Tony<br>
<br>
On Monday, 09 July, 2018 10:59 PM, James Cameron wrote:<br>
</div>
<blockquote type="cite"
cite="mid:sugarlabs%2Ffoodforce2-activity%2Fpull%2F1%2Fc403618655@github.com">
<p>We are not using git as a version control system only; we're
also using it as a change control system. So version number
changes are only needed when a new release of an activity is to
be made.</p>
<p>It is up to the contributor whether to include that in their
pull request. I'll accept pull requests with or without version
number changes; but if someone includes a version number change,
then I'll expect also;</p>
<ul>
<li>full testing of the activity features, (for which others can
help),</li>
<li>updated translations,</li>
<li>updated NEWS file,</li>
<li>review of licensing,</li>
<li>updated README.md file,</li>
<li>several other interesting things, see the <a
href="https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#checklist---maintainer"
moz-do-not-send="true">checklist - maintainer</a>,</li>
<li>the pull request to be "vN", where N is the version number.</li>
</ul>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
You are receiving this because you were mentioned.<br>
Reply to this email directly, <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1#issuecomment-403618655"
moz-do-not-send="true">view it on GitHub</a>, or <a
href="https://github.com/notifications/unsubscribe-auth/AAULkkPNjjdEQ_q1YPjpuKFIa1QSGIr-ks5uE8RJgaJpZM4VGwEv"
moz-do-not-send="true">mute the thread</a>.<img
src="https://github.com/notifications/beacon/AAULkhOxwJDsO2000DBRJVKycB5x855Iks5uE8RJgaJpZM4VGwEv.gif"
alt="" moz-do-not-send="true" width="1" height="1"></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/sugarlabs/foodforce2-activity","title":"sugarlabs/foodforce2-activity","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/sugarlabs/foodforce2-activity"}},"updates":{"snippets":[{"icon":"PERSON","message":"@quozl in #1: We are not using git as a version control system only; we're also using it as a change control system. So version number changes are only needed when a new release of an activity is to be made.\r\n\r\nIt is up to the contributor whether to include that in their pull request. I'll accept pull requests with or without version number changes; but if someone includes a version number change, then I'll expect also;\r\n* full testing of the activity features, (for which others can help),\r\n* updated translations,\r\n* updated NEWS file,\r\n* review of licensing,\r\n* updated README.md file,\r\n* several other interesting things, see the [checklist - maintainer](https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#checklist---maintainer),\r\n* the pull request to be \"vN\", where N is the version number."}],"action":{"name":"View Pull Request","url":"https://github.com/sugarlabs/foodforce2-activity/pull/1#issuecomment-403618655"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/sugarlabs/foodforce2-activity/pull/1#issuecomment-403618655",
"url": "https://github.com/sugarlabs/foodforce2-activity/pull/1#issuecomment-403618655",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [sugarlabs/foodforce2-activity] Port to Gtk+3 (#1)",
"sections": [
{
"text": "",
"activityTitle": "**James Cameron**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@quozl",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"sugarlabs/foodforce2-activity\",\n\"issueId\": 1,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"sugarlabs/foodforce2-activity\",\n\"pullRequestId\": 1\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/sugarlabs/foodforce2-activity/pull/1#issuecomment-403618655"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 354091311\n}"
}
],
"themeColor": "26292E"
}
]</script>
</blockquote>
<p><br>
</p>
</body>
</html>