<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">It seems incredible to see this many
changes to the activity, but no increment to the version number.
This seems to be a consistent pattern - a port to gtk+3 in
github/SugarLabs with the same version number as the original in
ASLO. If we were really to take advantage of git, the earliest
version in ASLO should be committed first. Each subsequent version
should be submitted as a new version. This would retain the
development history of the activity. The port to gtk+3 would then
be submitted as a new version retaining the software history.<br>
<br>
Tony<br>
<br>
On Sunday, 08 July, 2018 04:45 PM, Yash Agrawal wrote:<br>
</div>
<blockquote type="cite"
cite="mid:sugarlabs%2Ffoodforce2-activity%2Fpull%2F1@github.com">
<p><a class="user-mention" data-hovercard-user-id="2936481"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/quozl" moz-do-not-send="true">@quozl</a>
please review!</p>
<hr>
<h4>You can view, comment on, or merge this pull request online
at:</h4>
<p> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1"
moz-do-not-send="true">https://github.com/sugarlabs/foodforce2-activity/pull/1</a></p>
<h4>Commit Summary</h4>
<ul>
<li>remove pyc files and add .gitignore</li>
<li>port to GTK+3</li>
</ul>
<h4>File Changes</h4>
<ul>
<li> <strong>A</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-0"
moz-do-not-send="true">.gitignore</a> (1) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-1"
moz-do-not-send="true">MANIFEST</a> (184) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-2"
moz-do-not-send="true">MANIFEST.in</a> (9) </li>
<li> <strong>M</strong> <a
href="cid:part6.FEBA0C10.45388273@usa.net"
moz-do-not-send="false">activity/activity.info</a> (2) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-4"
moz-do-not-send="true">game_sharing.py</a> (2) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-5"
moz-do-not-send="true">olpc-setup.py</a> (2) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-6"
moz-do-not-send="true">olpcgames/__init__.pyc</a> (0) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-7"
moz-do-not-send="true">olpcgames/_version.pyc</a> (0) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-8"
moz-do-not-send="true">olpcgames/activity.py</a> (49) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-9"
moz-do-not-send="true">olpcgames/activity.pyc</a> (0) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-10"
moz-do-not-send="true">olpcgames/buildmanifest.py</a> (33) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-11"
moz-do-not-send="true">olpcgames/canvas.py</a> (33) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-12"
moz-do-not-send="true">olpcgames/canvas.pyc</a> (0) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-13"
moz-do-not-send="true">olpcgames/data/sleeping.svg</a> (52)
</li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-14"
moz-do-not-send="true">olpcgames/eventwrap.py</a> (2) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-15"
moz-do-not-send="true">olpcgames/eventwrap.pyc</a> (0) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-16"
moz-do-not-send="true">olpcgames/gtkEvent.py</a> (42) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-17"
moz-do-not-send="true">olpcgames/gtkEvent.pyc</a> (0) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-18"
moz-do-not-send="true">olpcgames/mesh.py</a> (6) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-19"
moz-do-not-send="true">olpcgames/mesh.pyc</a> (0) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-20"
moz-do-not-send="true">olpcgames/pangofont.py</a> (5) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-21"
moz-do-not-send="true">olpcgames/util.py</a> (2) </li>
<li> <strong>D</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-22"
moz-do-not-send="true">olpcgames/util.pyc</a> (0) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-23"
moz-do-not-send="true">olpcgames/video.py</a> (21) </li>
<li> <strong>M</strong> <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-24"
moz-do-not-send="true">setup.py</a> (2) </li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1.patch"
moz-do-not-send="true">https://github.com/sugarlabs/foodforce2-activity/pull/1.patch</a></li>
<li><a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1.diff"
moz-do-not-send="true">https://github.com/sugarlabs/foodforce2-activity/pull/1.diff</a></li>
</ul>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
You are receiving this because you are subscribed to this
thread.<br>
Reply to this email directly, <a
href="https://github.com/sugarlabs/foodforce2-activity/pull/1"
moz-do-not-send="true">view it on GitHub</a>, or <a
href="https://github.com/notifications/unsubscribe-auth/AAULkkNtPwuPWbGJsfWbKSG-VaLYP9aYks5uEhsjgaJpZM4VGwEv"
moz-do-not-send="true">mute the thread</a>.<img
src="https://github.com/notifications/beacon/AAULkv9yYzTxVP7v72pGWd_K1voWJgXOks5uEhsjgaJpZM4VGwEv.gif"
alt="" moz-do-not-send="true" width="1" height="1"></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/sugarlabs/foodforce2-activity","title":"sugarlabs/foodforce2-activity","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/sugarlabs/foodforce2-activity"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Port to Gtk+3 (#1)"}],"action":{"name":"View Pull Request","url":"https://github.com/sugarlabs/foodforce2-activity/pull/1"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/sugarlabs/foodforce2-activity/pull/1",
"url": "https://github.com/sugarlabs/foodforce2-activity/pull/1",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Port to Gtk+3 (#1)",
"sections": [
{
"text": "",
"activityTitle": "**Yash Agrawal**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@yashagrawal3",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "3941bc5",
"value": "remove pyc files and add .gitignore"
},
{
"name": "66ed873",
"value": "port to GTK+3"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Added",
"value": "[.gitignore](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-0) (1 changes)"
},
{
"name": "Removed",
"value": "[MANIFEST](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-1) (184 changes)"
},
{
"name": "Removed",
"value": "[MANIFEST.in](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-2) (9 changes)"
},
{
"name": "Modified",
"value": "[activity/activity.info](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-3) (2 changes)"
},
{
"name": "Modified",
"value": "[game_sharing.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-4) (2 changes)"
},
{
"name": "Modified",
"value": "[olpc-setup.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-5) (2 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/__init__.pyc](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-6) (0 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/_version.pyc](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-7) (0 changes)"
},
{
"name": "Modified",
"value": "[olpcgames/activity.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-8) (49 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/activity.pyc](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-9) (0 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/buildmanifest.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-10) (33 changes)"
},
{
"name": "Modified",
"value": "[olpcgames/canvas.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-11) (33 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/canvas.pyc](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-12) (0 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/data/sleeping.svg](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-13) (52 changes)"
},
{
"name": "Modified",
"value": "[olpcgames/eventwrap.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-14) (2 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/eventwrap.pyc](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-15) (0 changes)"
},
{
"name": "Modified",
"value": "[olpcgames/gtkEvent.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-16) (42 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/gtkEvent.pyc](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-17) (0 changes)"
},
{
"name": "Modified",
"value": "[olpcgames/mesh.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-18) (6 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/mesh.pyc](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-19) (0 changes)"
},
{
"name": "Modified",
"value": "[olpcgames/pangofont.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-20) (5 changes)"
},
{
"name": "Modified",
"value": "[olpcgames/util.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-21) (2 changes)"
},
{
"name": "Removed",
"value": "[olpcgames/util.pyc](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-22) (0 changes)"
},
{
"name": "Modified",
"value": "[olpcgames/video.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-23) (21 changes)"
},
{
"name": "Modified",
"value": "[setup.py](https://github.com/sugarlabs/foodforce2-activity/pull/1/files#diff-24) (2 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"sugarlabs/foodforce2-activity\",\n\"issueId\": 1,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"sugarlabs/foodforce2-activity\",\n\"pullRequestId\": 1\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/sugarlabs/foodforce2-activity/pull/1"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/sugarlabs/foodforce2-activity/pull/1.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/sugarlabs/foodforce2-activity/pull/1.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 354091311\n}"
}
],
"themeColor": "26292E"
}
]</script>
</blockquote>
<p><br>
</p>
</body>
</html>