<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
What 'finer points' do you feel are outstanding? <br>
<br>
<p>Here is the checklist -</p>
<ul class="contains-task-list">
<li draggable="false" class="task-list-item enabled"><span
class="handle"><svg viewBox="0 0 16 15" version="1.1"
height="15" width="16" aria-hidden="true"
class="drag-handle"><path
d="M12,4V5H4V4h8ZM4,8h8V7H4V8Zm0,3h8V10H4v1Z"></path></svg></span><input
class="task-list-item-checkbox" checked="checked"
type="checkbox"> Flake8 in alerts.py fixed<br>
Please note - There are already existing flake8 errors before
this PR. I would suggest fixing them in a separate PR rather
than including in this one.</li>
<li draggable="false" class="task-list-item enabled"><span
class="handle"><svg viewBox="0 0 16 15" version="1.1"
height="15" width="16" aria-hidden="true"
class="drag-handle"><path
d="M12,4V5H4V4h8ZM4,8h8V7H4V8Zm0,3h8V10H4v1Z"></path></svg></span><input
class="task-list-item-checkbox" checked="checked"
type="checkbox"> Branch rebased to the latest commit.</li>
<li draggable="false" class="task-list-item enabled"><span
class="handle"><svg viewBox="0 0 16 15" version="1.1"
height="15" width="16" aria-hidden="true"
class="drag-handle"><path
d="M12,4V5H4V4h8ZM4,8h8V7H4V8Zm0,3h8V10H4v1Z"></path></svg></span><input
class="task-list-item-checkbox" checked="checked"
type="checkbox"> Variable name use for gsettings is <code>'_save_as_enabled'</code>
since another variable with <code>_save_as</code> name has
already been used in lot of places. And there are other existing
gsettings variables in Sugar which go by this naming style - <code>gsetting_name_enabled</code>
so should not be a problem.</li>
<li draggable="false" class="task-list-item enabled"><span
class="handle"><svg viewBox="0 0 16 15" version="1.1"
height="15" width="16" aria-hidden="true"
class="drag-handle"><path
d="M12,4V5H4V4h8ZM4,8h8V7H4V8Zm0,3h8V10H4v1Z"></path></svg></span><input
class="task-list-item-checkbox" checked="checked"
type="checkbox"> Commit message updated with reference page</li>
<li draggable="false" class="task-list-item enabled"><span
class="handle"><svg viewBox="0 0 16 15" version="1.1"
height="15" width="16" aria-hidden="true"
class="drag-handle"><path
d="M12,4V5H4V4h8ZM4,8h8V7H4V8Zm0,3h8V10H4v1Z"></path></svg></span><input
class="task-list-item-checkbox" checked="checked"
type="checkbox"> Check settings everytime rather than save it
at startup</li>
<li draggable="false" class="task-list-item enabled"><span
class="handle"><svg viewBox="0 0 16 15" version="1.1"
height="15" width="16" aria-hidden="true"
class="drag-handle"><path
d="M12,4V5H4V4h8ZM4,8h8V7H4V8Zm0,3h8V10H4v1Z"></path></svg></span><input
class="task-list-item-checkbox" checked="checked"
type="checkbox"> Add new <code>GConf</code> value to sugar
schema for Save-As<br>
PR - <a href="https://github.com/sugarlabs/sugar/pull/751"
class="issue-link js-issue-link"
data-url="https://github.com/sugarlabs/sugar/issues/751"
data-id="224177683" data-error-text="Failed to load issue
title" data-permission-text="Issue title is private">sugarlabs/sugar#751</a></li>
<li class="task-list-item enabled"><span class="handle"><svg
viewBox="0 0 16 15" version="1.1" height="15" width="16"
aria-hidden="true" class="drag-handle"><path
d="M12,4V5H4V4h8ZM4,8h8V7H4V8Zm0,3h8V10H4v1Z"></path></svg></span><input
class="task-list-item-checkbox" checked="checked"
type="checkbox"> Add save-as functionality to <code>sugar-toolkit</code><br>
PR - <a title="SaveAs Pop on Activity Close"
href="https://github.com/sugarlabs/sugar-toolkit/pull/4"
class="issue-link js-issue-link" data-id="166284140"
data-error-text="Failed to load issue title"
data-permission-text="Issue title is private">sugarlabs/sugar-toolkit#4</a></li>
</ul>
Utkarsh shows that he has addressed all of the issues.<br>
<br>
Tony<br>
<br>
<div class="moz-cite-prefix">On 04/26/2017 03:52 PM, James Cameron
wrote:<br>
</div>
<blockquote
cite="mid:sugarlabs%2Fsugar%2Fpull%2F752%2Fc297276054@github.com"
type="cite">
<p>I don't think they have appreciated the finer points that are
discovered on careful review of the patch, and it is those finer
points I've asked Utkarsh to respond to. No need to list them
again, as they are over on <a moz-do-not-send="true"
href="https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/327"
class="issue-link js-issue-link"
data-url="https://github.com/sugarlabs/sugar-toolkit-gtk3/issues/327"
data-id="163710007" data-error-text="Failed to load issue
title" data-permission-text="Issue title is private">sugarlabs/sugar-toolkit-gtk3#327</a></p>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
You are receiving this because you commented.<br>
Reply to this email directly, <a moz-do-not-send="true"
href="https://github.com/sugarlabs/sugar/pull/752#issuecomment-297276054">view
it on GitHub</a>, or <a moz-do-not-send="true"
href="https://github.com/notifications/unsubscribe-auth/AAULkp1zFxICgK9uNbGe8PNJKpzggkgHks5rzve0gaJpZM4NIV2L">mute
the thread</a>.<img moz-do-not-send="true" alt=""
src="https://github.com/notifications/beacon/AAULkooI1c_CPvRRDDRWL6uSKoS2GcsDks5rzve0gaJpZM4NIV2L.gif"
height="1" width="1"></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope=""
itemtype="http://schema.org/ViewAction">
<link itemprop="url"
href="https://github.com/sugarlabs/sugar/pull/752#issuecomment-297276054">
<meta itemprop="name" content="View Pull Request">
</div>
<meta itemprop="description" content="View this Pull Request on
GitHub">
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/sugarlabs/sugar","title":"sugarlabs/sugar","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/sugarlabs/sugar"}},"updates":{"snippets":[{"icon":"PERSON","message":"@quozl in #752: I don't think they have appreciated the finer points that are discovered on careful review of the patch, and it is those finer points I've asked Utkarsh to respond to. No need to list them again, as they are over on https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/327"}],"action":{"name":"View Pull Request","url":"https://github.com/sugarl
a
bs/sugar/pull/752#issuecomment-297276054"}}}</script>
</blockquote>
<br>
</body>
</html>