<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
As you may know, I submitted this feature for GSOC17. Along with
Sebastian Silva, I worked as a mentor on this project. <br>
<br>
The feature was modeled on the way most document processors work.
They offer the ability to save or save as the document. Save is used
when the document has already been saved and so uses the same path.
Save as gives the user the chance to change the name and/or path.
Normally a save issued without a prior save as is treated as save
as. AFAIK, this feature did not appear in Sugar because of the
desire in the HIG to avoid the file menu and the appearance of a
'desktop'. It is my understanding that search tags (a la Picasa)
would offer the organization normally found in directories. However,
this was not implemented. <br>
<br>
Gimp is an example of the behavior expected of the feature. Sugar
commander is only relevant to your comment that Sugar does not have
a file system. Of course it does - it choses not to make that
visible to its users. <br>
<br>
I completely agree with James Simmons. It should have been. We want
our users to grow into a confident understanding of how computers
work. This includes an understanding of the file system. I would
like to see the Documents and removable devices shown in the Journal
as a hierarchy. This would not be difficult technically and would
facilitate dealing with usb drives with many files. One technique
could be to use the directory names on a usb stick as tags The user
could search for files in a directory using the name as a tag. <br>
<br>
I would certainly appreciate improvements to performance of the
frame key. In writing code in Sugar, it is essential to open and
close it frequently to switch between activities. You should
certainly raise the issue again so we have a chance to benefit. Only
applying to the XO covers the overwhelming majority of our users. So
I really don't undertand why you met any resistance.<br>
<br>
I would certainly like to understand this developer collaboration
and review process. Utkarsh has jumped through every hoop. The PR
shows that all issues raised have been satisfied. To accommodate
those who would prefer not to see this change in the Sugar UI, it is
controlled by a setting with the default that it is not enabled.<br>
<br>
The PR works much the same way as the corresponding feature for
screenshots. I don't even know if Utkarsh requires a non-blank
screenshot title. The setting of the default to false was used with
the PR for the 'resume' feature which has been merged.<br>
<br>
I assume this process is intended to ensure that a PR request does
not break Sugar, is compatible with Sugar and its HIG, and meets
reasonable and publicly documented technical standards. <br>
<br>
PR #327 meets these criteria. The only roadblock to its merger seems
to be you and your personal opinions.<br>
<br>
Tony<br>
<br>
<div class="moz-cite-prefix">On 04/26/2017 03:32 PM, James Cameron
wrote:<br>
</div>
<blockquote
cite="mid:sugarlabs%2Fsugar-toolkit-gtk3%2Fpull%2F327%2Fc297267641@github.com"
type="cite">
<p>Gimp is not relevant, because this patch is to Sugar, not
Gnome. You can't use Gimp with the Sugar Journal. Sugar
Commander is also not relevant.</p>
<p>Where you say "all that is needed is for you to merge", that's
trivialising the developer collaboration and review process for
Sugar.</p>
<p>You can always maintain your own fork if you like; and that is
what I've already had to do because of my patches that Sugar
Labs has not accepted, such as the performance improvements to
the frame f6 key. I respect that my patches may not have
universal appeal; since they only helped XO users.</p>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
You are receiving this because you were mentioned.<br>
Reply to this email directly, <a moz-do-not-send="true"
href="https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/327#issuecomment-297267641">view
it on GitHub</a>, or <a moz-do-not-send="true"
href="https://github.com/notifications/unsubscribe-auth/AAULkhaiN3JONu-rIMEKpQsVBSDydyMoks5rzvMPgaJpZM4JEg63">mute
the thread</a>.<img moz-do-not-send="true" alt=""
src="https://github.com/notifications/beacon/AAULksPV2bT4WePxIWkS9NvX8YcswwqPks5rzvMPgaJpZM4JEg63.gif"
height="1" width="1"></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope=""
itemtype="http://schema.org/ViewAction">
<link itemprop="url"
href="https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/327#issuecomment-297267641">
<meta itemprop="name" content="View Pull Request">
</div>
<meta itemprop="description" content="View this Pull Request on
GitHub">
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/sugarlabs/sugar-toolkit-gtk3","title":"sugarlabs/sugar-toolkit-gtk3","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/sugarlabs/sugar-toolkit-gtk3"}},"updates":{"snippets":[{"icon":"PERSON","message":"@quozl in #327: Gimp is not relevant, because this patch is to Sugar, not Gnome. You can't use Gimp with the Sugar Journal. Sugar Commander is also not relevant.\r\n\r\nWhere you say \"all that is needed is for you to merge\", that's trivialising the developer collaboration and review process for Sugar.\r\n\r\nYou can a
l
ways maintain your own fork if you like; and that is what I've already had to do because of my patches that Sugar Labs has not accepted, such as the performance improvements to the frame f6 key. I respect that my patches may not have universal appeal; since they only helped XO users."}],"action":{"name":"View Pull Request","url":"https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/327#issuecomment-297267641"}}}</script>
</blockquote>
<br>
</body>
</html>