Hi,<div><br></div><div>First, I would like to comment about the tone of the PR discussion. I believe that as a community, our tone on that discussion was probably worse that usual. I once read this interesting article about design reviews at Facebook [1], which contained the line:</div><div><br></div><div>> Criticism belittles the designer — <span class="markup--strong markup--blockquote-strong">Critique improves the design</span></div><div><br></div><div>That is what we need to keep in mind when reviewing patches too.</div><div><br></div><div>Thanks,</div><div>Sam</div><div><br></div><div>[1] <a href="https://medium.com/facebook-design/critique-is-an-important-part-of-any-design-process-whether-you-work-as-part-of-a-team-or-solo-ef3dcb299ce3">https://medium.com/facebook-design/critique-is-an-important-part-of-any-design-process-whether-you-work-as-part-of-a-team-or-solo-ef3dcb299ce3</a><br><div><span class="markup--strong markup--blockquote-strong" style="font-weight: 700;"><br></span></div><div><br>On Mon, Jul 11, 2016 at 6:23 PM, Tony Anderson <tony_anderson@usa.net> wrote:<br>
<blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;">Hi, Utkarsh
I must apologize for trashing your PR. It takes a lot to get me angry, but yesterday I was. After complaining that we did not send emails of all of our technical discussions to Sugar_dev and then asking for our IRC meetings to be publicly logged, they ignored all of our discussion and asked the same questions on the PR that we had already answered before over and over.
I appreciate your comments. They show a clear understanding of the feature and an ability to express yourself clearly. Since your PR is an implementation of a requirement set by me, your response referencing me was appropriate and the response you got, out of line.
To me the essence of this feature is two-fold:
1. To require users to supply a title-supplied-by-user.
2. To enable users to resume an activity, make some changes and then decide to make the result a new instance - preserving the original. This is why
the feature is called 'save as', because that is how user's do this in most document-handling applications. Currently, this is not possible in Sugar.
I don't know if it is possible, but I would suggest withdrawing this PR and creating a new one - same code, of course. Then I think there needs to be a gif animation and explanation of the feature. At that point, comments would be welcome.
My understanding of this is the PR is the developer's presentation of the result of their work to be reviewed for merging into the master. It is not a design forum. Before work is done on creating the code represented by the PR, the design should be done. No developer can code without knowing the intended outcome. Naturally, comments on the PR may result in changes to the code but changes made from a working base.
In the end, the developer's may indeed reject this and other PRs and thus prevent many Sugar users from benefiting from them. That would be sad. However, it is open source and it certainly can and will use be used in deployments. This, of course, is one of the great freedoms in free software.
Tony
</div></blockquote></div></div>