<div dir="ltr"><div><div><div>Hi all, </div><div> </div>The proxy feature implementation looks complete now. <a href="https://github.com/sugarlabs/sugar/pull/665">https://github.com/sugarlabs/sugar/pull/665</a> </div>Hence, please review it and provide suggestions. :) </div><div>Shall I update the feature page for the same? <a href="https://wiki.sugarlabs.org/go/Features/Proxy_Settings">https://wiki.sugarlabs.org/go/Features/Proxy_Settings</a> </div><div>Thanks. </div><div>Regards </div><div>Manash Pratim Das (ManashRaja) </div></div><div class="gmail_extra"> <div class="gmail_quote">On Wed, Mar 16, 2016 at 3:27 AM, James Cameron <<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Mar 16, 2016 at 01:57:06AM +0530, Manash Raja wrote: > Dear James, > > Regarding moving to src/jarabe/main.py , as far as I know, there > isn't a direct way for python to set the required environment > variables (http_proxy) and make it accessible to all other > processes. The various method in python for editing the environment > variables, keeps the changes limited to only that process or its > child processes. Hence if the implementation is done through > main.py, other files to run bash scripts have to be introduced. I disagree. src/jarabe/main.py already sets several environment variables that are inherited by activity processes, so there is no need to run shell scripts. You should test again. Take particular note of variables such as SUGAR_VERSION, and TZ. SUGAR_VERSION is set during startup with this; os.environ['SUGAR_VERSION'] = config.version TZ is set by reading a Gio.Settings instance with this; def setup_timezone(): settings = Gio.Settings('org.sugarlabs.date') timezone = settings.get_string('timezone') if timezone is not None and timezone: os.environ['TZ'] = timezone There is no benefit to using /usr/bin/sugar instead, and your proposed change is very resource intensive because of multiple activation of gsettings binary. > So, to me it seems exporting proxy settings to the environment > variables at /usr/bin/sugar is a fine implementation. Though we can > use variables to reduce gsettings calls in that file. > > I would definitely look at the branch based development from next time. > > Tell me if I shall reduce gsettings call in /usr/bin/sugar file and continue > with the present implementation or look for any other implementation that you > suggest. Once the feature is final for merge, I will collapse/rebase the > commits with new commit message and update the PR. > > Thanks. > > Regards. > Manash Pratim Das (ManashRaja) > > On Tue, Mar 15, 2016 at 10:39 AM, James Cameron <[1]<a href="mailto:quozl@laptop.org">quozl@laptop.org</a>> wrote: > > Thanks, that's interesting. > > Your /usr/bin/sugar (aka bin/[2]<a href="http://sugar.in" rel="noreferrer" target="_blank">sugar.in</a>) will run gsettings many times, > and this is inefficient, causing unnecessary delay during startup. > Perhaps if you move this into src/jarabe/main.py which already uses > Gio.Settings? > > You have worked on your master branch and the pull request is > associated with that branch. That's unusual. It is more common to > use a new branch with a name that explains the feature. Make a note > of that for next time. > > Your pull request has three commits; 09d363f, 682d0b2, 4fe1a2f. > Before merging, we will ask for these and later commits to be > collapsed, rebased, or re-written. You may also combine and rewrite > the commit messages. Then a push with --force will update the pull > request. > > The [3]<a href="http://wiki.sugarlabs.org/go/Features/Proxy_Settings" rel="noreferrer" target="_blank">http://wiki.sugarlabs.org/go/Features/Proxy_Settings</a> page is on a <div><div class="h5">> Wiki, and any change can be rolled back. > > On Tue, Mar 15, 2016 at 09:58:31AM +0530, Manash Raja wrote: > > Hi, > > > > I thank you all for the guidance. > > > > I modified my PR as per your suggestions and now the implementation of > the > > proxy feature is far better. > > @Sam, as you suggested, I have now completely removed the need of > re-writing > > "proxy.sh" every time the settings changes and am using > > "org.gnome.system.proxy" schemas. Now "/usr/bin/sugar" is hard-coded to > read > > the proxy settings from "org.gnome.system.proxy" and export it to the > > environment variables required for the proxy settings to be available > easily. > > > > @Gonzalo, thanks for the link to that important patch from Manuel > Quiñones. And > > @James, I have changed my "view.py" and "model.py" files to go with > Manuel > > Quiñones' way of setting the "org.gnome.system.proxy" schemas via > GSettings. > > This has hence removed the dependence on polkit for file write > permissions and > > made us do away with extra files like "set_proxy.py" for running root > permitted > > scripts. > > > > Also I have removed the "logout.sh" script as now I am using the pre-made > > "require-restart" feature present in "sectionview" which asks the user > for > > restart. > > > > Also @James, shall I now therefore submit the GUI changes and the changes > you </div></div>> > proposed to for this update in the features page? [1][4] > <a href="http://wiki.sugarlabs.org/go/" rel="noreferrer" target="_blank">wiki.sugarlabs.org/go/</a> > > Features/Proxy_Settings > > > > Here is the patch I submitted: [2][5]<a href="https://github.com/ManashRaja/sugar/" rel="noreferrer" target="_blank">https://github.com/ManashRaja/sugar/</a> > commit/ > > 4fe1a2fea7f37d036331c1a1ae736c88cc29d62d > > > > Thanks > > Regards > > Manash Pratim Das > > > > On Mon, Mar 14, 2016 at 8:03 AM, James Cameron <[3][6]<a href="mailto:quozl@laptop.org">quozl@laptop.org</a>> > wrote: > > > > On Sun, Mar 13, 2016 at 11:18:46PM -0300, Gonzalo Odiard wrote: > > > On Sun, Mar 13, 2016 at 11:09 PM, Jerry Vonau <[1][4][7] > <a href="mailto:me@jvonau.ca">me@jvonau.ca</a>> wrote: > > > > > > > Yea that has roots to the old ActivityCentral fork, any reason > > > > why this has not been 'upstreamed' from OneEducation(OLPC-AU) to > > > > SugarLabs? > > > > > > Yes. Was not accepted by sugar upstream. > > > > Let's have another go then. See what the objections are from the > > current set of developers. > > > > > I upstreamed all that was possible, the only changes that were > > > developed just for OLPC-AU were the changes needed to deal with the > > > complex network environments common in Australian schools. > > > > This disease is spreading. > > > > -- > > James Cameron > > [5][8]<a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a> > > _______________________________________________ > > Sugar-devel mailing list > > [6][9]<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> > > [7][10]<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > > > > References: > > > > [1] [11]<a href="http://wiki.sugarlabs.org/go/Features/Proxy_Settings" rel="noreferrer" target="_blank">http://wiki.sugarlabs.org/go/Features/Proxy_Settings</a> > > [2] [12]<a href="https://github.com/ManashRaja/sugar/commit/" rel="noreferrer" target="_blank">https://github.com/ManashRaja/sugar/commit/</a> > 4fe1a2fea7f37d036331c1a1ae736c88cc29d62d > > [3] mailto:[13]<a href="mailto:quozl@laptop.org">quozl@laptop.org</a> > > [4] mailto:[14]<a href="mailto:me@jvonau.ca">me@jvonau.ca</a> > > [5] [15]<a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a> > > [6] mailto:[16]<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> > > [7] [17]<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > > -- > James Cameron > [18]<a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a> > > References: > > [1] mailto:<a href="mailto:quozl@laptop.org">quozl@laptop.org</a> > [2] <a href="http://sugar.in/" rel="noreferrer" target="_blank">http://sugar.in/</a> > [3] <a href="http://wiki.sugarlabs.org/go/Features/Proxy_Settings" rel="noreferrer" target="_blank">http://wiki.sugarlabs.org/go/Features/Proxy_Settings</a> > [4] <a href="http://wiki.sugarlabs.org/go/" rel="noreferrer" target="_blank">http://wiki.sugarlabs.org/go/</a> > [5] <a href="https://github.com/ManashRaja/sugar/commit/" rel="noreferrer" target="_blank">https://github.com/ManashRaja/sugar/commit/</a> > [6] mailto:<a href="mailto:quozl@laptop.org">quozl@laptop.org</a> > [7] mailto:<a href="mailto:me@jvonau.ca">me@jvonau.ca</a> > [8] <a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a> > [9] mailto:<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> > [10] <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > [11] <a href="http://wiki.sugarlabs.org/go/Features/Proxy_Settings" rel="noreferrer" target="_blank">http://wiki.sugarlabs.org/go/Features/Proxy_Settings</a> > [12] <a href="https://github.com/ManashRaja/sugar/commit/4fe1a2fea7f37d036331c1a1ae736c88cc29d62d" rel="noreferrer" target="_blank">https://github.com/ManashRaja/sugar/commit/4fe1a2fea7f37d036331c1a1ae736c88cc29d62d</a> > [13] mailto:<a href="mailto:quozl@laptop.org">quozl@laptop.org</a> > [14] mailto:<a href="mailto:me@jvonau.ca">me@jvonau.ca</a> > [15] <a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a> > [16] mailto:<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> > [17] <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > [18] <a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a> <div class="HOEnZb"><div class="h5"> -- James Cameron <a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a> </div></div></blockquote></div> </div>