<div dir="ltr"><br><div>Look great. Nice work, almost ready to be deployed !</div><div>Few things you need to consider for this activity (and for other activities in the Sugar Activity Set):</div><div><div style="font-size:12.8px">- Ensure that your app is responsive: so it will fit on any device size (PC, tablet, smartphone). To simplify the work of developers we could however imagine that the width should be always greater than the height. Seems to work on Moon.</div><div style="font-size:12.8px">- Ensure that your app could work on any browsers so you could at least ensure that it work on Chrome, Firefox and if possible on Safari, IE and Edge.</div><div style="font-size:12.8px">- Ensure that your app could be localized in different languages, so think to isolate strings in your source code. Usually we're using the webL10n.js library for that [1]. It should be include in the Sugarizer ActivityTemplate.</div></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Best regards.</div><div><br></div><div> Lionel.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-03-20 10:51 GMT+01:00 Shirsh Zibbu <span dir="ltr"><<a href="mailto:zibs.shirsh@gmail.com" target="_blank">zibs.shirsh@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hello. I apologize for not replying earlier.<div>I have finally worked out all the problems mentioned below and updated the <a href="http://t.sidekickopen04.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs4WrKXjN8q-6Y2dnqP2VRzDdF56dC9ff6Yjdzx02?t=https%3A%2F%2Fzhirzh.github.io%2Fsugarizer-activity-moon%2F&si=5100779840208896&pi=3796c3e3-50c8-487b-d234-21195a7f53d0" target="_blank">demo</a>.</div><div><br></div><div>Please try it out and see if any more problems persist. I'd be more swift at making amends this time onward.</div><div><br></div><div>Bugs fixed:</div><div><ul><li></li><li>the data is offset from current date and time by several hours</li><li>there is no compass direction marker or latitude longitude color legend when grid view is enabled</li><li>the toggle hemisphere view toggle button may become out of synchronization with the displayed image</li><li>the moon does not fit in Sugar Browse</li></ul></div><img src="http://t.sidekickopen04.com/e1t/o/5/f18dQhb0S7ks8dDMPbW2n0x6l2B9gXrN7sKj6v5dpzgMfDnr4QJSGMVd0ts23LvrVvW3p7XfD1k1H6H0?si=5100779840208896&pi=3796c3e3-50c8-487b-d234-21195a7f53d0" style="display:none!important" height="1" width="1"></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 14, 2016 at 8:39 AM, James Cameron <span dir="ltr"><<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Out of synchronisation is mismatch between button state and moon<br> image. It happens on first click with empty cache or fresh browser<br> instance. It does not happen on page refresh.<br> <br> Reproducer:<br> <br> 1. start Firefox and open<br> <a href="http://zhirzh.github.io/sugarizer-activity-moon/" rel="noreferrer" target="_blank">http://zhirzh.github.io/sugarizer-activity-moon/</a><br> <br> 2. wait for loading to complete,<br> <br> 3. click once in the Toggle Hemisphere View button,<br> <br> Expected result: both the button and moon image should change state.<br> <br> Observed result: only the button changes state.<br> <br> 4. click again in the Toggle Hemisphere View button,<br> <br> Observed result: both the button and moon image change state.<br> <span><br> On Fri, Mar 11, 2016 at 06:22:44PM +0530, Shirsh Zibbu wrote:<br> > Okay. I've just finished figuring out the causes of the problems:<br> ><br> </span>> • timezone problem is happening because js [1]Date() works with local<br> <span>> timezone, unless explicitly told to use GMT. needs some time, since<br> > 'daylight saving' can also become an issue<br> ><br> > • i haven't yet implemented compass and legend. will do in the following<br> > days.<br> ><br> > • i do not understand what you meant by 'out of<br> > synchronisation'. i believe it means the button shows activated, even when<br> > the moon is not flipped (or vice versa). I hope I got that right. (more<br> > screenshots?)<br> ><br> > • the problem with Sugar Browse is due to the fact that I am using css<br> > transforms to center the canvas. apparently, some css features do not<br> > work everywhere. will switch to js for centering.<br> ><br> > if any more problems pop up, please do tell me. i'd happy to correct them.<br> </span>> *<br> <span>><br> > On Fri, Mar 11, 2016 at 4:52 AM, James Cameron <[2]<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>> wrote:<br> ><br> > Your link is too long to copy and paste, but this link works fine:<br> ><br> </span>> [3]<a href="http://zhirzh.github.io/sugarizer-activity-moon/" rel="noreferrer" target="_blank">http://zhirzh.github.io/sugarizer-activity-moon/</a><br> <span>><br> > I've tested using Firefox-45 on Ubuntu 14.04:<br> ><br> > 1. the data is offset from current date and time by several hours,<br> ><br> > (the today's moon information, next full moon, new moon, lunar<br> > eclipse, and solar eclipse times are presented as GMT+1100 (AEDT) yet<br> > the dates and times are exactly the same as the Moon activity on an XO<br> > laptop, which presents them as GMT, see attached screenshots,)<br> ><br> > 2. there is no compass direction marker or latitude longitude colour<br> > legend when grid view is enabled,<br> ><br> > 3. the toggle hemisphere view toggle button may become out of<br> > synchronisation with the displayed image,<br> ><br> > I've also tested using Sugar Browse from git on Fedora 18 using an XO<br> > laptop; the moon does not fit, see last of the attached screenshots.<br> ><br> > Good progress.<br> ><br> > On Fri, Mar 11, 2016 at 04:20:49AM +0530, Shirsh Zibbu wrote:<br> > > *<br> > > I have made some major progress in the past week in the project Sugarizer<br> > > Activity Set. To be precise, I have been porting Moon activity. I have<br> > prepared<br> > > a [1]demo for the same.<br> > ><br> > > I would like to know other's opinions, especially the project mentor, sir<br> > > Lionel Laské and sir Michaël Ohayon, regarding my current work and what<br> > all<br> > > changes are needed.<br> > ><br> > > References:<br> > ><br> </span>> > [1] [4]<a href="http://t.sidekickopen46.com/e1t/c/5/" rel="noreferrer" target="_blank">http://t.sidekickopen46.com/e1t/c/5/</a><br> > f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs4WrKXjN8q-6Y2dnqP2VRzDdF56dC9ff6Yjdzx02?<br> > t=http%3A%2F%<a href="http://2Fzhirzh.github.io" rel="noreferrer" target="_blank">2Fzhirzh.github.io</a>%2Fsugarizer-activity-moon%2F&si=<br> > 5100779840208896&pi=9738b7b8-0b1c-4a15-e4f2-9d8e700508b2<br> ><br> > > _______________________________________________<br> > > Sugar-devel mailing list<br> > > [5]<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br> > > [6]<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> ><br> ><br> > --<br> > James Cameron<br> > [7]<a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a><br> ><br> > References:<br> ><br> > [1] <a href="http://t.sidekickopen46.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs4WrKXjN8q-6Y2dnqP2VRzDdF56dC9ff6Yjdzx02?t=https%3A%2F%2Fdeveloper.mozilla.org%2Fen%2Fdocs%2FWeb%2FJavaScript%2FReference%2FGlobal_Objects%2FDate&si=5100779840208896&pi=229fc1f0-7077-4812-b483-e132a0e3741b" rel="noreferrer" target="_blank">http://t.sidekickopen46.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs4WrKXjN8q-6Y2dnqP2VRzDdF56dC9ff6Yjdzx02?t=https%3A%2F%2Fdeveloper.mozilla.org%2Fen%2Fdocs%2FWeb%2FJavaScript%2FReference%2FGlobal_Objects%2FDate&si=5100779840208896&pi=229fc1f0-7077-4812-b483-e132a0e3741b</a><br> > [2] mailto:<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a><br> > [3] <a href="http://zhirzh.github.io/sugarizer-activity-moon/" rel="noreferrer" target="_blank">http://zhirzh.github.io/sugarizer-activity-moon/</a><br> > [4] <a href="http://t.sidekickopen46.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs4WrKXjN8q-6Y2dnqP2VRzDdF56dC9ff6Yjdzx02?t=http%3A%2F%2Fzhirzh.github.io%2Fsugarizer-activity-moon%2F&si=5100779840208896&pi=9738b7b8-0b1c-4a15-e4f2-9d8e700508b2" rel="noreferrer" target="_blank">http://t.sidekickopen46.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x6l2B9nMJW7t5XZs4WrKXjN8q-6Y2dnqP2VRzDdF56dC9ff6Yjdzx02?t=http%3A%2F%2Fzhirzh.github.io%2Fsugarizer-activity-moon%2F&si=5100779840208896&pi=9738b7b8-0b1c-4a15-e4f2-9d8e700508b2</a><br> > [5] mailto:<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br> > [6] <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> > [7] <a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a><span class="HOEnZb"><font color="#888888"><br> <div><div><br> --<br> James Cameron<br> <a href="http://quozl.netrek.org/" rel="noreferrer" target="_blank">http://quozl.netrek.org/</a><br> </div></div></font></span></blockquote></div><br></div> </blockquote></div><br></div>